Sign upLogin

matteoferla/Fragmenstein

View on GitHub
Star
fragmenstein/monster/positional_mapping.py

Summary

Maintainability
A
2 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

        if dummy_w_dummy and \
                zeroth.GetSymbol() == '*' and \
                first.GetSymbol() == '*':
            distance = 9999
            dummy_distance = measure_distance(confs[0].GetAtomPosition(i), confs[1].GetAtomPosition(j))
Severity: Major
Found in fragmenstein/monster/positional_mapping.py - About 1 hr to fix

    Function _gpm_distance has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def _gpm_distance(cls, mols: List[Chem.Mol], confs: [Chem.Conformer], i, j, dummy_w_dummy=True) \
            -> Tuple[float, float, float]:
        """
        See get_positional_distance
    Severity: Minor
    Found in fragmenstein/monster/positional_mapping.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _gpm_distance has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _gpm_distance(cls, mols: List[Chem.Mol], confs: [Chem.Conformer], i, j, dummy_w_dummy=True) \
    Severity: Minor
    Found in fragmenstein/monster/positional_mapping.py - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status