matteolc/t2_airtime

View on GitHub

Showing 31 of 31 total issues

Function prototype has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
Open

Searcher.prototype = new function() {
  // search is performed in chunks of 1000 for non-blocking user input
  var CHUNK_SIZE = 1000;
  // do not try to find more than 100 results
  var MAX_RESULTS = 100;
Severity: Minor
Found in rdoc/js/searcher.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function prototype has 160 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Searcher.prototype = new function() {
  // search is performed in chunks of 1000 for non-blocking user input
  var CHUNK_SIZE = 1000;
  // do not try to find more than 100 results
  var MAX_RESULTS = 100;
Severity: Major
Found in rdoc/js/searcher.js - About 6 hrs to fix

    File serializer.rb has 348 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module T2Airtime
    
      class Topup
    
        def self.serialize(data, ts = Time.zone.now.to_s)
    Severity: Minor
    Found in lib/t2_airtime/serializer.rb - About 4 hrs to fix

      Function prototype has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

      Search.prototype = $.extend({}, Navigation, new function() {
        var suid = 1;
      
        this.init = function() {
          var _this = this;
      Severity: Minor
      Found in rdoc/js/search.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method serialize_one has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.serialize_one(data, ts = Time.zone.now.to_s)
            Rails.cache.fetch("transactions/#{data[:transactionid]}/serializer", expires_in: 365.days) do
              {
                type: 'transactions',
                id: Integer(data[:transactionid]),
      Severity: Minor
      Found in lib/t2_airtime/serializer.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function prototype has 82 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Search.prototype = $.extend({}, Navigation, new function() {
        var suid = 1;
      
        this.init = function() {
          var _this = this;
      Severity: Major
      Found in rdoc/js/search.js - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for (var i=1, l = regexps.length; i < l; i++) {
              result.title = result.title.replace(regexps[i], highlighters[i]);
              result.namespace = result.namespace.replace(regexps[i], highlighters[i]);
            };
        Severity: Major
        Found in rdoc/js/searcher.js and 1 other location - About 3 hrs to fix
        rdoc/js/searcher.js on lines 139..142

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for (var i=0, l = regexps.length; i < l; i++) {
              result.title = result.title.replace(regexps[i], highlighters[i]);
              result.namespace = result.namespace.replace(regexps[i], highlighters[i]);
            };
        Severity: Major
        Found in rdoc/js/searcher.js and 1 other location - About 3 hrs to fix
        rdoc/js/searcher.js on lines 161..164

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method serialize_one has 63 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def self.serialize_one(data, ts = Time.zone.now.to_s)
              Rails.cache.fetch("transactions/#{data[:transactionid]}/serializer", expires_in: 365.days) do
                {
                  type: 'transactions',
                  id: Integer(data[:transactionid]),
        Severity: Major
        Found in lib/t2_airtime/serializer.rb - About 2 hrs to fix

          Method topup has 17 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def topup(msisdn, destination_msisdn, product, method = 'topup',
                        reserved_id = nil, send_sms = true, sms = nil, sender_text = nil,
                        cid1 = '', cid2 = '', cid3 = '',
                        operator_id = nil,
                        return_service_fee = 1, delivered_amount_info = 1, return_timestamp = 1, return_version = 1,
          Severity: Major
          Found in lib/t2_airtime/api.rb - About 2 hrs to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                for (var i=1, l = regexps.length; i < l; i++) {
                  if (!index.match(regexps[i]) && !longIndex.match(regexps[i]))
                    return false;
                };
            Severity: Major
            Found in rdoc/js/searcher.js and 2 other locations - About 1 hr to fix
            rdoc/js/searcher.js on lines 115..118
            rdoc/js/searcher.js on lines 128..131

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                for (var i=1, l = regexps.length; i < l; i++) {
                  if (!index.match(regexps[i]) && !longIndex.match(regexps[i]))
                    return false;
                };
            Severity: Major
            Found in rdoc/js/searcher.js and 2 other locations - About 1 hr to fix
            rdoc/js/searcher.js on lines 89..92
            rdoc/js/searcher.js on lines 115..118

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                for (var i=1, l = regexps.length; i < l; i++) {
                  if (!index.match(regexps[i]) && !longIndex.match(regexps[i]))
                    return false;
                };
            Severity: Major
            Found in rdoc/js/searcher.js and 2 other locations - About 1 hr to fix
            rdoc/js/searcher.js on lines 89..92
            rdoc/js/searcher.js on lines 128..131

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method serialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def self.serialize(data, ts = Time.zone.now.to_s, qty = 'all')
                  return [] if data[:product_list].nil?
                  ids = data[:product_list].split(',')
                  retail_prices = data[:retail_price_list].split(',')
                  wholesale_prices = data[:wholesale_price_list].split(',')
            Severity: Minor
            Found in lib/t2_airtime/serializer.rb - About 1 hr to fix

              Function performSearch has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                function performSearch(data, regexps, queries, highlighters, state) {
                  var searchIndex = data.searchIndex;
                  var longSearchIndex = data.longSearchIndex;
                  var info = data.info;
                  var result = [];
              Severity: Minor
              Found in rdoc/js/searcher.js - About 1 hr to fix

                Method serialize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    def self.serialize(data, ts = Time.zone.now.to_s)
                      {
                        type: 'topup',
                        balance: data[:balance],
                        balanceDisplay: "#{Money.new(Integer(data[:balance]) * 100, Account.currency).format}",
                Severity: Minor
                Found in lib/t2_airtime/serializer.rb - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        case 38: //Event.KEY_UP:
                          if (e.keyCode == 38 || e.ctrlKey) {
                            if (this.moveUp()) e.preventDefault();
                            this.startMoveTimeout(false);
                          }
                  Severity: Major
                  Found in rdoc/js/navigation.js and 1 other location - About 1 hr to fix
                  rdoc/js/navigation.js on lines 55..60

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 62.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        case 40: //Event.KEY_DOWN:
                          if (e.keyCode == 40 || e.ctrlKey) {
                            if (this.moveDown()) e.preventDefault();
                            this.startMoveTimeout(true);
                          }
                  Severity: Major
                  Found in rdoc/js/navigation.js and 1 other location - About 1 hr to fix
                  rdoc/js/navigation.js on lines 46..51

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 62.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method serialize has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      def self.serialize(data, ts = Time.zone.now.to_s, qty = 'all')
                        return [] if data[:operator].nil?
                        names = data[:operator].split(',')
                        ids = data[:operatorid].split(',')
                        Rails.cache.fetch("operators/#{data[:countryid]}/serializer", expires_in: 1.hour) do
                  Severity: Minor
                  Found in lib/t2_airtime/serializer.rb - About 1 hr to fix

                    Function onkeydown has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      this.onkeydown = function(e) {
                        if (!this.navigationActive) return;
                        switch(e.keyCode) {
                          case 37: //Event.KEY_LEFT:
                            if (this.moveLeft()) e.preventDefault();
                    Severity: Minor
                    Found in rdoc/js/navigation.js - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language