matteolc/t2_airtime

View on GitHub

Showing 22 of 31 total issues

Function prototype has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
Open

Searcher.prototype = new function() {
  // search is performed in chunks of 1000 for non-blocking user input
  var CHUNK_SIZE = 1000;
  // do not try to find more than 100 results
  var MAX_RESULTS = 100;
Severity: Minor
Found in rdoc/js/searcher.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function prototype has 160 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Searcher.prototype = new function() {
  // search is performed in chunks of 1000 for non-blocking user input
  var CHUNK_SIZE = 1000;
  // do not try to find more than 100 results
  var MAX_RESULTS = 100;
Severity: Major
Found in rdoc/js/searcher.js - About 6 hrs to fix

    File serializer.rb has 348 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module T2Airtime
    
      class Topup
    
        def self.serialize(data, ts = Time.zone.now.to_s)
    Severity: Minor
    Found in lib/t2_airtime/serializer.rb - About 4 hrs to fix

      Function prototype has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

      Search.prototype = $.extend({}, Navigation, new function() {
        var suid = 1;
      
        this.init = function() {
          var _this = this;
      Severity: Minor
      Found in rdoc/js/search.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method serialize_one has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.serialize_one(data, ts = Time.zone.now.to_s)
            Rails.cache.fetch("transactions/#{data[:transactionid]}/serializer", expires_in: 365.days) do
              {
                type: 'transactions',
                id: Integer(data[:transactionid]),
      Severity: Minor
      Found in lib/t2_airtime/serializer.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function prototype has 82 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Search.prototype = $.extend({}, Navigation, new function() {
        var suid = 1;
      
        this.init = function() {
          var _this = this;
      Severity: Major
      Found in rdoc/js/search.js - About 3 hrs to fix

        Method serialize_one has 63 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def self.serialize_one(data, ts = Time.zone.now.to_s)
              Rails.cache.fetch("transactions/#{data[:transactionid]}/serializer", expires_in: 365.days) do
                {
                  type: 'transactions',
                  id: Integer(data[:transactionid]),
        Severity: Major
        Found in lib/t2_airtime/serializer.rb - About 2 hrs to fix

          Method topup has 17 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def topup(msisdn, destination_msisdn, product, method = 'topup',
                        reserved_id = nil, send_sms = true, sms = nil, sender_text = nil,
                        cid1 = '', cid2 = '', cid3 = '',
                        operator_id = nil,
                        return_service_fee = 1, delivered_amount_info = 1, return_timestamp = 1, return_version = 1,
          Severity: Major
          Found in lib/t2_airtime/api.rb - About 2 hrs to fix

            Method serialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def self.serialize(data, ts = Time.zone.now.to_s, qty = 'all')
                  return [] if data[:product_list].nil?
                  ids = data[:product_list].split(',')
                  retail_prices = data[:retail_price_list].split(',')
                  wholesale_prices = data[:wholesale_price_list].split(',')
            Severity: Minor
            Found in lib/t2_airtime/serializer.rb - About 1 hr to fix

              Function performSearch has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                function performSearch(data, regexps, queries, highlighters, state) {
                  var searchIndex = data.searchIndex;
                  var longSearchIndex = data.longSearchIndex;
                  var info = data.info;
                  var result = [];
              Severity: Minor
              Found in rdoc/js/searcher.js - About 1 hr to fix

                Method serialize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    def self.serialize(data, ts = Time.zone.now.to_s)
                      {
                        type: 'topup',
                        balance: data[:balance],
                        balanceDisplay: "#{Money.new(Integer(data[:balance]) * 100, Account.currency).format}",
                Severity: Minor
                Found in lib/t2_airtime/serializer.rb - About 1 hr to fix

                  Method serialize has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      def self.serialize(data, ts = Time.zone.now.to_s, qty = 'all')
                        return [] if data[:operator].nil?
                        names = data[:operator].split(',')
                        ids = data[:operatorid].split(',')
                        Rails.cache.fetch("operators/#{data[:countryid]}/serializer", expires_in: 1.hour) do
                  Severity: Minor
                  Found in lib/t2_airtime/serializer.rb - About 1 hr to fix

                    Function onkeydown has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      this.onkeydown = function(e) {
                        if (!this.navigationActive) return;
                        switch(e.keyCode) {
                          case 37: //Event.KEY_LEFT:
                            if (this.moveLeft()) e.preventDefault();
                    Severity: Minor
                    Found in rdoc/js/navigation.js - About 1 hr to fix

                      Method take has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def self.take(start = (Time.now - 24.hours), stop = Time.now, msisdn = nil, destination = nil, code = nil, qty = 5)
                      Severity: Minor
                      Found in lib/t2_airtime/serializer.rb - About 45 mins to fix

                        Method msisdn_info has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def msisdn_info(destination_msisdn,
                                            operator_id = nil,
                                            delivered_amount_info = 1, return_service_fee = 1, return_promo = 1)
                        Severity: Minor
                        Found in lib/t2_airtime/api.rb - About 35 mins to fix

                          Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def initialize(user, password, url, name, params)
                          Severity: Minor
                          Found in lib/t2_airtime/request.rb - About 35 mins to fix

                            Function performSearch has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                              function performSearch(data, regexps, queries, highlighters, state) {
                            Severity: Minor
                            Found in rdoc/js/searcher.js - About 35 mins to fix

                              Method transaction_list has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  def transaction_list(start = (Time.now - 24.hours), stop = Time.now, msisdn = nil, destination = nil, code = nil)
                              Severity: Minor
                              Found in lib/t2_airtime/api.rb - About 35 mins to fix

                                Method alpha3 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    def self.alpha3(name)
                                      alpha3 = ISO3166::Country.find_country_by_name(name).try(:alpha3)
                                      unless alpha3
                                        alpha3 = case name
                                                 when 'Saint Vincent Grenadines'
                                Severity: Minor
                                Found in lib/t2_airtime/serializer.rb - About 35 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function hookSearch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                function hookSearch() {
                                  var input  = $('#search-field').eq(0);
                                  var result = $('#search-results').eq(0);
                                  $(result).show();
                                
                                
                                Severity: Minor
                                Found in rdoc/js/darkfish.js - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language