Sign upLogin

matteozambon89/marko-router

View on GitHub
Star

Showing 6 of 6 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  _getStateRootDefaultState(stateRoot) {
    stateRoot = stateRoot || this._stateRoot

    this._logLine('[MarkoRouter] _getStatePath.{stateRoot}: ' + stateRoot)
Severity: Major
Found in MarkoRouter.js and 1 other location - About 3 hrs to fix
MarkoRouter.js on lines 101..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  _getStateRootBase(stateRoot) {
    stateRoot = stateRoot || this._stateRoot

    this._logLine('[MarkoRouter] _getStatePath.{stateRoot}: ' + stateRoot)
Severity: Major
Found in MarkoRouter.js and 1 other location - About 3 hrs to fix
MarkoRouter.js on lines 124..139

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

MarkoRouter has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

class MarkoRouter extends EventEmitter {
  constructor(attr) {
    super()

    this._debug = typeof attr === 'object' && attr.debug ? attr.debug : false
Severity: Minor
Found in MarkoRouter.js - About 3 hrs to fix

    Function _defPageRoute has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _defPageRoute(state, route) {
    this._logLine('[MarkoRouter] _defPageRoute.{state}: ' + state)
    this._logLine('[MarkoRouter] _defPageRoute.{route.path}: ' + route.path)

    // Set a Page Route and use a function as handler
    Severity: Minor
    Found in MarkoRouter.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        _emitPageInit(args) {
    this._logLine('[MarkoRouter] _emitPageInit.{args}: ')
    this._logLine(args)

    this.emit('page.init', args)
      Severity: Minor
      Found in MarkoRouter.js and 1 other location - About 35 mins to fix
      MarkoRouter.js on lines 390..395

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        _emitChangeState(args) {
    this._logLine('[MarkoRouter] _emitChangeState.{args}: ')
    this._logLine(args)

    this.emit('state.change', args)
      Severity: Minor
      Found in MarkoRouter.js and 1 other location - About 35 mins to fix
      MarkoRouter.js on lines 403..408

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language