Sign upLogin

matthew-matvei/freeman

View on GitHub
Star
src/renderer/components/panels/DirectoryList.tsx

Summary

Maintainability
D
2 days
Test Coverage

File DirectoryList.tsx has 424 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import autobind from "autobind-decorator";
import { remote } from "electron";
import { List } from "immutable";
import path from "path";
import * as PropTypes from "prop-types";
Severity: Minor
Found in src/renderer/components/panels/DirectoryList.tsx - About 6 hrs to fix

    DirectoryList has 34 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class DirectoryList extends React.Component<IDirectoryListProps, IDirectoryListState> {

    /** Context available within a ScrollArea. */
    public context: { scrollArea: any };
    Severity: Minor
    Found in src/renderer/components/panels/DirectoryList.tsx - About 4 hrs to fix

      Function pasteFromClipboard has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @autobind
    private async pasteFromClipboard() {
        const { directoryManager, settingsManager } = this.props;
        const { clipboardAction, clipboardItems } = this.model;
      Severity: Minor
      Found in src/renderer/components/panels/DirectoryList.tsx - About 1 hr to fix

        Function render has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public render(): JSX.Element {
        const items = this.renderItems();

        return (
            <div className="DirectoryList">
        Severity: Minor
        Found in src/renderer/components/panels/DirectoryList.tsx - About 1 hr to fix

          Function componentDidUpdate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public async componentDidUpdate(prevProps: IDirectoryListProps, prevState: IDirectoryListState) {
        const { directoryManager, settingsManager } = this.props;

        this.props.statusNotifier.setItemCount(this.nonHiddenDirectoryItems.length);
        this.props.statusNotifier.setChosenCount(this.state.chosenItems.length);
          Severity: Minor
          Found in src/renderer/components/panels/DirectoryList.tsx - About 1 hr to fix

            Function move has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                @autobind
    private move(direction: DirectoryDirection) {
        if (direction === "up") {
            if (this.state.selectedIndex > 0) {
                this.setState(prevState => ({ selectedIndex: prevState.selectedIndex - 1 } as IDirectoryListState));
            Severity: Minor
            Found in src/renderer/components/panels/DirectoryList.tsx - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function pasteFromClipboard has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                @autobind
    private async pasteFromClipboard() {
        const { directoryManager, settingsManager } = this.props;
        const { clipboardAction, clipboardItems } = this.model;
            Severity: Minor
            Found in src/renderer/components/panels/DirectoryList.tsx - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                        this.setState(
                {
                    directoryItems: await directoryManager.listDirectory(
                        this.props.path,
                        { hideUnixStyleHiddenItems: settingsManager.settings.windows.hideUnixStyleHiddenItems })
            Severity: Major
            Found in src/renderer/components/panels/DirectoryList.tsx and 2 other locations - About 1 hr to fix
            src/renderer/components/panels/DirectoryList.tsx on lines 425..430
            src/renderer/components/panels/DirectoryList.tsx on lines 549..554

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                            this.setState(
                    {
                        directoryItems: await directoryManager.listDirectory(
                            this.props.path,
                            { hideUnixStyleHiddenItems: settingsManager.settings.windows.hideUnixStyleHiddenItems })
            Severity: Major
            Found in src/renderer/components/panels/DirectoryList.tsx and 2 other locations - About 1 hr to fix
            src/renderer/components/panels/DirectoryList.tsx on lines 425..430
            src/renderer/components/panels/DirectoryList.tsx on lines 441..446

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                        this.setState(
                {
                    directoryItems: await directoryManager.listDirectory(
                        this.props.path,
                        { hideUnixStyleHiddenItems: settingsManager.settings.windows.hideUnixStyleHiddenItems })
            Severity: Major
            Found in src/renderer/components/panels/DirectoryList.tsx and 2 other locations - About 1 hr to fix
            src/renderer/components/panels/DirectoryList.tsx on lines 441..446
            src/renderer/components/panels/DirectoryList.tsx on lines 549..554

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                @autobind
    private openGoto() {
        if (!this.state.isGotoOpen) {
            this.setState({ isGotoOpen: true } as IDirectoryListState);
        }
            Severity: Major
            Found in src/renderer/components/panels/DirectoryList.tsx and 1 other location - About 1 hr to fix
            src/renderer/components/App.tsx on lines 125..130

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                @autobind
    private closeGoto() {
        if (this.state.isGotoOpen) {
            this.setState({ isGotoOpen: false } as IDirectoryListState);
        }
            Severity: Minor
            Found in src/renderer/components/panels/DirectoryList.tsx and 1 other location - About 55 mins to fix
            src/renderer/components/App.tsx on lines 117..122

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        Utils.trace(`Requesting to delete ${this.selectedItems.map(item => item.path).join(", ")}`);
            Severity: Minor
            Found in src/renderer/components/panels/DirectoryList.tsx and 1 other location - About 40 mins to fix
            src/renderer/components/panels/DirectoryList.tsx on lines 524..524

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        Utils.trace(`Requesting to trash ${this.selectedItems.map(item => item.path).join(", ")}`);
            Severity: Minor
            Found in src/renderer/components/panels/DirectoryList.tsx and 1 other location - About 40 mins to fix
            src/renderer/components/panels/DirectoryList.tsx on lines 296..296

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    const chosenItems = this.selectedItems.length > 1 ? "the chosen items" : `'${this.selectedItems[0].name}'`;
            Severity: Minor
            Found in src/renderer/components/panels/DirectoryList.tsx and 1 other location - About 35 mins to fix
            src/renderer/components/panels/DirectoryList.tsx on lines 516..516

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    const chosenItems = this.selectedItems.length > 1 ? "the chosen items" : `'${this.selectedItems[0].name}'`;
            Severity: Minor
            Found in src/renderer/components/panels/DirectoryList.tsx and 1 other location - About 35 mins to fix
            src/renderer/components/panels/DirectoryList.tsx on lines 288..288

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status