Sign upLogin

matthucke/graveyards4

View on GitHub
Star
app/controllers/legacy_controller.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method show has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

  def show
    # First look for id=NNN; if we find it it's a simple graveyard path.
    if id=params[:id]
      if id.to_i > 0
        if @graveyard = Graveyard.find(id) rescue nil
Severity: Minor
Found in app/controllers/legacy_controller.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method show has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def show
    # First look for id=NNN; if we find it it's a simple graveyard path.
    if id=params[:id]
      if id.to_i > 0
        if @graveyard = Graveyard.find(id) rescue nil
Severity: Minor
Found in app/controllers/legacy_controller.rb - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                url += ".#{fmt}" unless fmt.blank?
    Severity: Major
    Found in app/controllers/legacy_controller.rb - About 45 mins to fix

      Method find_graveyard has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def find_graveyard county, graveyard_path
    g = lookup_graveyard(county, graveyard_path)
    return g if g

    if graveyard_path =~ /(.*)-Cemetery/
      Severity: Minor
      Found in app/controllers/legacy_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status