mbland/custom-links

View on GitHub

Showing 15 of 25 total issues

File app.js has 821 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-env browser */
'use strict';

(function(f) { f(window, document) })(function(window,  document) {
  var cl = window.cl = {}
Severity: Major
Found in public/app.js - About 1 day to fix

    Function assembleApiRouter has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function assembleApiRouter(linkDb, logger) {
      var router = express.Router(),
          jsonParser = bodyParser.json(),
          linkParam = ':link(/[A-Za-z0-9_.-]+)',
          userParam = ':user([A-Za-z0-9_.-]+@?[A-Za-z0-9_.-]+)'
    Severity: Major
    Found in lib/index.js - About 2 hrs to fix

      Function exports has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(config) {
        var options = {
          basePath: '../public',
      
          // frameworks: https://npmjs.org/browse/keyword/karma-adapter
      Severity: Major
      Found in .config/karma.conf.js - About 2 hrs to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          router.post('/create' + linkParam, jsonParser, (req, res) => {
            addApiHandlers(req, res, 201, logger, linkDb.createLink(
              req.params.link, req.body.target, req.user.id))
          })
        Severity: Major
        Found in lib/index.js and 2 other locations - About 1 hr to fix
        lib/index.js on lines 132..135
        lib/index.js on lines 137..140

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          router.post('/owner' + linkParam, jsonParser, (req, res) => {
            addApiHandlers(req, res, 204, logger, linkDb.changeOwner(
              req.params.link, req.user.id, req.body.owner))
          })
        Severity: Major
        Found in lib/index.js and 2 other locations - About 1 hr to fix
        lib/index.js on lines 115..118
        lib/index.js on lines 137..140

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          router.post('/target' + linkParam, jsonParser, (req, res) => {
            addApiHandlers(req, res, 204, logger, linkDb.updateTarget(
              req.params.link, req.user.id, req.body.target))
          })
        Severity: Major
        Found in lib/index.js and 2 other locations - About 1 hr to fix
        lib/index.js on lines 115..118
        lib/index.js on lines 132..135

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function createLinksTable has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          cl.createLinksTable = function(links, linksView, options) {
            var linkTable = cl.getTemplate('links'),
                linkEntry = cl.getTemplate('link'),
                sortKey,
                order
        Severity: Minor
        Found in public/app.js - About 1 hr to fix

          Function Dialog has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            cl.Dialog = function(templateName, data, startOperation, resultElement) {
              var dialog = this,
                  errPrefix = 'The "' + templateName + '" dialog box template '
          
              this.name = templateName
          Severity: Minor
          Found in public/app.js - About 1 hr to fix

            Function linksView has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              cl.linksView = function() {
                var element = cl.getTemplate('links-view'),
                    linksView = new cl.View(element, function() {
                      cl.focusFirstElement(element, 'a')
                    })
            Severity: Minor
            Found in public/app.js - About 1 hr to fix

              Function xhr has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                cl.xhr = function(method, url, body) {
                  return new Promise(function(resolve, reject) {
                    var r = new XMLHttpRequest()
              
                    r.open(method, url, true)
              Severity: Minor
              Found in public/app.js - About 1 hr to fix

                Function assembleApp has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function assembleApp(app, linkDb, logger, sessionStore, config) {
                  auth.assemble(passport, linkDb, config)
                  app.use(session(sessionParams(config, sessionStore)))
                  app.use(passport.initialize())
                  app.use(passport.session())
                Severity: Minor
                Found in lib/index.js - About 1 hr to fix

                  Function exports has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                  module.exports = function(config) {
                    var options = {
                      basePath: '../public',
                  
                      // frameworks: https://npmjs.org/browse/keyword/karma-adapter
                  Severity: Minor
                  Found in .config/karma.conf.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function makeApiCall has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    cl.Backend.prototype.makeApiCall = function(method, endpoint, linkInfo,
                      params, okMsg, errPrefix) {
                  Severity: Minor
                  Found in public/app.js - About 45 mins to fix

                    Function assembleApp has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    function assembleApp(app, linkDb, logger, sessionStore, config) {
                    Severity: Minor
                    Found in lib/index.js - About 35 mins to fix

                      Function addApiHandlers has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function addApiHandlers(req, res, okStatus, logger, linkDbOp) {
                      Severity: Minor
                      Found in lib/index.js - About 35 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language