Sign upLogin

mbleigh/acts-as-taggable-on

View on GitHub
Star
lib/acts_as_taggable_on/taggable/collection.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method all_tag_counts has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def all_tag_counts(options = {})
          options = options.dup
          options.assert_valid_keys :start_at, :end_at, :conditions, :at_least, :at_most, :order, :limit, :on, :id

          ## Generate conditions:
Severity: Minor
Found in lib/acts_as_taggable_on/taggable/collection.rb - About 1 hr to fix

    Method tagging_conditions has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def tagging_conditions(options)
          tagging_conditions = []
          if options[:end_at]
            tagging_conditions.push sanitize_sql(["#{ActsAsTaggableOn::Tagging.table_name}.created_at <= ?",
                                                  options.delete(:end_at)])
    Severity: Minor
    Found in lib/acts_as_taggable_on/taggable/collection.rb - About 1 hr to fix

      Method tagging_conditions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

              def tagging_conditions(options)
          tagging_conditions = []
          if options[:end_at]
            tagging_conditions.push sanitize_sql(["#{ActsAsTaggableOn::Tagging.table_name}.created_at <= ?",
                                                  options.delete(:end_at)])
      Severity: Minor
      Found in lib/acts_as_taggable_on/taggable/collection.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method all_tag_counts has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

              def all_tag_counts(options = {})
          options = options.dup
          options.assert_valid_keys :start_at, :end_at, :conditions, :at_least, :at_most, :order, :limit, :on, :id

          ## Generate conditions:
      Severity: Minor
      Found in lib/acts_as_taggable_on/taggable/collection.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status