Sign upLogin

mbroadst/rethunk

View on GitHub
Star

Showing 396 of 396 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    for (var i = 0; i < self._healthyPools.length; i++) {
      if (self._healthyPools[i] === this) {
        self._healthyPools.splice(i, 1);
        self.emitStatus();
        break;
Severity: Minor
Found in lib/pool_master.js and 1 other location - About 45 mins to fix
lib/pool_master.js on lines 444..450

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

error.ReqlOpIndeterminateError = function(message, query, frames) {
  error.ReqlRuntimeError.call(this, message, query, frames);
  this.name = 'ReqlOpIndeterminateError';
};
Severity: Major
Found in lib/error.js and 5 other locations - About 45 mins to fix
lib/error.js on lines 128..131
lib/error.js on lines 137..140
lib/error.js on lines 146..149
lib/error.js on lines 155..158
lib/error.js on lines 173..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    } else {
      args.push(new Term(this._r).expr(_args[_args.length - 1])._wrap());
    }
Severity: Minor
Found in lib/term.js and 1 other location - About 40 mins to fix
lib/term.js on lines 813..815

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  if (_args.length> 0) {
    args.push(new Term(this._r).expr(_args[_args.length-1])._wrap());
  }
Severity: Minor
Found in lib/term.js and 1 other location - About 40 mins to fix
lib/term.js on lines 878..880

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Consider simplifying this complex logical expression.
Open

      if ((key !== 'shards') && (key !== 'replicas') &&
        (key !== 'dryRun') && (key !== 'primaryReplicaTag') &&
        (key !== 'nonvotingReplicaTags') && (key !== 'emergencyRepair')) {
        throw new errors.ReqlDriverError('Unrecognized option `'+key+'` in `reconfigure`', self._query, 'Available options are shards: <number>, replicas: <number>, primaryReplicaTag: <object>, dryRun <boolean>, emergencyRepair: <string>, nonvotingReplicaTags: <array<string>>');
      }
Severity: Major
Found in lib/term.js - About 40 mins to fix

    Function TABLE has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      TABLE: function(term, index, father, frames, options) {
    Severity: Minor
    Found in lib/error.js - About 35 mins to fix

      Function generateNormalBacktrace has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function generateNormalBacktrace(term, index, father, frames, options) {
      Severity: Minor
      Found in lib/error.js - About 35 mins to fix

        Function _arityRange has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        Term.prototype._arityRange = function(args, min, max, method, term) {
        Severity: Minor
        Found in lib/term.js - About 35 mins to fix

          Function GET_FIELD has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            GET_FIELD: function(term, index, father, frames, options) {
          Severity: Minor
          Found in lib/error.js - About 35 mins to fix

            Function IMPLICIT_VAR has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              IMPLICIT_VAR: function(term, index, father, frames, options) {
            Severity: Minor
            Found in lib/error.js - About 35 mins to fix

              Function MAP has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                MAP: function(term, index, father, frames, options) {
              Severity: Minor
              Found in lib/error.js - About 35 mins to fix

                Function WAIT has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  WAIT: function(term, index, father, frames, options) {
                Severity: Minor
                Found in lib/error.js - About 35 mins to fix

                  Function generateWithoutPrefixBacktrace has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function generateWithoutPrefixBacktrace(term, index, father, frames, options) {
                  Severity: Minor
                  Found in lib/error.js - About 35 mins to fix

                    Function FUNC has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                      FUNC: function(term, index, father, frames, options) {
                    Severity: Minor
                    Found in lib/error.js - About 35 mins to fix

                      Function generateBacktrace has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function generateBacktrace(term, index, father, frames, options) {
                      Severity: Minor
                      Found in lib/error.js - About 35 mins to fix

                        Function VAR has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                          VAR: function(term, index, father, frames, options) {
                        Severity: Minor
                        Found in lib/error.js - About 35 mins to fix

                          Function MAKE_ARRAY has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                            MAKE_ARRAY: function(term, index, father, frames, options) {
                          Severity: Minor
                          Found in lib/error.js - About 35 mins to fix

                            Function FUNCALL has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                              FUNCALL: function(term, index, father, frames, options) {
                            Severity: Minor
                            Found in lib/error.js - About 35 mins to fix

                              Function random has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                              Term.prototype.random = function() {
  var _len = arguments.length; var _args = new Array(_len);
  for (var _i = 0; _i < _len; _i++) {_args[_i] = arguments[_i];}
  var self = this;
  self._noPrefix(this, 'random');
                              Severity: Minor
                              Found in lib/term.js - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function _flush has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                              Cursor.prototype._flush = function() {
  while ((this._pendingPromises.length > 0) && ((this._data.length > 0) || ((this._fetching === false) && (this._canFetch === false)))) {
    var fullfiller = this._pendingPromises.shift();
    var resolve = fullfiller.resolve;
    var reject = fullfiller.reject;
                              Severity: Minor
                              Found in lib/cursor.js - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language