Sign upLogin

mcmartins/jsondbfs

View on GitHub
Star

Showing 24 of 24 total issues

Function update has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
Open

Collection.prototype.update = function update(criteria, updateCriteria, options, callback) {
  if (typeof options === 'function') {
    callback = options;
    options = undefined;
  }
Severity: Minor
Found in lib/collection.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function connect has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

module.exports.connect = function (collections, options, callback) {
  if (typeof collections === 'function') {
    callback = collections;
    collections = undefined;
  }
Severity: Minor
Found in index.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Collection.prototype.update = function update(criteria, updateCriteria, options, callback) {
  if (typeof options === 'function') {
    callback = options;
    options = undefined;
  }
Severity: Major
Found in lib/collection.js - About 3 hrs to fix

    Function find has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

    Collection.prototype.find = function find(criteria, options, callback) {
  if (typeof options === 'function') {
    callback = options;
    options = undefined;
  }
    Severity: Minor
    Found in lib/collection.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File collection.js has 283 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * (C) Copyright 2015 Manuel Martins.
 *
 * This module is inspired by json_file_system.
 * (json_file_system is Copyright (c) 2014 Jalal Hejazi,
    Severity: Minor
    Found in lib/collection.js - About 2 hrs to fix

      Function connect has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports.connect = function (collections, options, callback) {
  if (typeof collections === 'function') {
    callback = collections;
    collections = undefined;
  }
      Severity: Major
      Found in index.js - About 2 hrs to fix

        Function Memory has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

        function Memory(options) {
  options = options || {};
  var self = this;
  self.flush = options.db._db._memory.flush || false;
  self.flushInterval = options.db._db._memory.flushInterval || 10000;
        Severity: Minor
        Found in lib/memory.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function afterLockFile has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          self._dataHandler.lock(function afterLockFile(err) {
    if (err) {
      return callback(err);
    }
    self._dataHandler.get(function afterReadFile(err, documents) {
        Severity: Minor
        Found in lib/collection.js - About 1 hr to fix

          Function afterReadFile has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              self._dataHandler.get(function afterReadFile(err, documents) {
      if (err) {
        self._dataHandler.unlock();
        return callback(err);
      }
          Severity: Minor
          Found in lib/collection.js - About 1 hr to fix

            Function insert has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

            Collection.prototype.insert = function insert(data, callback) {
  if (typeof data === 'function' || !data) {
    callback = data;
    data = undefined;
  }
            Severity: Minor
            Found in lib/collection.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function remove has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

            Collection.prototype.remove = function remove(criteria, options, callback) {
  if (typeof options === 'function') {
    callback = options;
    options = {
      multi: true
            Severity: Minor
            Found in lib/collection.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function find has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            Collection.prototype.find = function find(criteria, options, callback) {
  if (typeof options === 'function') {
    callback = options;
    options = undefined;
  }
            Severity: Minor
            Found in lib/collection.js - About 1 hr to fix

              Function remove has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              Collection.prototype.remove = function remove(criteria, options, callback) {
  if (typeof options === 'function') {
    callback = options;
    options = {
      multi: true
              Severity: Minor
              Found in lib/collection.js - About 1 hr to fix

                Function insert has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                Collection.prototype.insert = function insert(data, callback) {
  if (typeof data === 'function' || !data) {
    callback = data;
    data = undefined;
  }
                Severity: Minor
                Found in lib/collection.js - About 1 hr to fix

                  Function attachOrCreateCollections has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      function attachOrCreateCollections() {
      if (!_.isArray(collections)) {
        collections = [collections];
      }
      // in parallel initialize each collection
                  Severity: Minor
                  Found in index.js - About 1 hr to fix

                    Function Memory has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function Memory(options) {
  options = options || {};
  var self = this;
  self.flush = options.db._db._memory.flush || false;
  self.flushInterval = options.db._db._memory.flushInterval || 10000;
                    Severity: Minor
                    Found in lib/memory.js - About 1 hr to fix

                      Function afterFilter has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                            }, function afterFilter(err, filteredDocuments) {
        if (err) {
          self._dataHandler.unlock();
          return callback(err);
        }
                      Severity: Minor
                      Found in lib/collection.js - About 1 hr to fix

                        Function findAndModify has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        Collection.prototype.findAndModify = function findAndModify(criteria, updateCriteria, options, callback) {
  if (typeof options === 'function') {
    callback = options;
    options = undefined;
  }
                        Severity: Minor
                        Found in lib/collection.js - About 1 hr to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          Memory.prototype.lock = function lock(callback) {
  process.nextTick(function(){
    callback = callback || defaultCallback;
    return callback(undefined);
  });
                          Severity: Major
                          Found in lib/memory.js and 1 other location - About 1 hr to fix
                          lib/memory.js on lines 123..128

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 56.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          Memory.prototype.unlock = function unlock(callback) {
  process.nextTick(function(){
    callback = callback || defaultCallback;
    return callback(undefined);
  });
                          Severity: Major
                          Found in lib/memory.js and 1 other location - About 1 hr to fix
                          lib/memory.js on lines 111..116

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 56.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language