mconf/mconf-web

View on GitHub
app/models/site.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method social_login_enabled? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def social_login_enabled?(method=nil)
    if method == "google"
      Rails.application.config.omniauth_google_key.present? && Rails.application.config.omniauth_google_secret.present?
    elsif method == "facebook"
      Rails.application.config.omniauth_facebook_key.present? && Rails.application.config.omniauth_facebook_secret.present?
Severity: Minor
Found in app/models/site.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_and_adjust_max_upload_size has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def validate_and_adjust_max_upload_size
    if max_upload_size_changed?
      if self.max_upload_size.blank?
        write_attribute(:max_upload_size, nil)
      else
Severity: Minor
Found in app/models/site.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status