mcred/Cred-Jumper

View on GitHub
src/Credential.php

Summary

Maintainability
A
0 mins
Test Coverage

The parameter $login_url is not named in camelCase.
Open

    public function __construct(string $username, string $password, string $login_url)
    {
        $this->username = $username;
        $this->password = $password;
        $this->login_url = $login_url;
Severity: Minor
Found in src/Credential.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $login_url is not named in camelCase.
Open

class Credential
{
    private $username;
    private $password;
    private $login_url;
Severity: Minor
Found in src/Credential.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The variable $login_url is not named in camelCase.
Open

    public function __construct(string $username, string $password, string $login_url)
    {
        $this->username = $username;
        $this->password = $password;
        $this->login_url = $login_url;
Severity: Minor
Found in src/Credential.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status