Sign upLogin

mcred/FeedMeNow-PHP

View on GitHub
Star
src/FeedMeNow/Model/Restaurant.php

Summary

Maintainability
B
4 hrs
Test Coverage

Restaurant has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class Restaurant
{
    private $id;
    private $name;
    private $imageUrl;
Severity: Minor
Found in src/FeedMeNow/Model/Restaurant.php - About 2 hrs to fix

    Method __construct has 18 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $id,
        $name,
        $imageUrl,
        $isClaimed,
        $isClosed,
    Severity: Major
    Found in src/FeedMeNow/Model/Restaurant.php - About 2 hrs to fix

      The class Restaurant has 18 fields. Consider redesigning Restaurant to keep the number of fields under 15.
      Open

      class Restaurant
{
    private $id;
    private $name;
    private $imageUrl;
      Severity: Minor
      Found in src/FeedMeNow/Model/Restaurant.php by phpmd

      TooManyFields

      Since: 0.1

      Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

      Example

      class Person {
   protected $one;
   private $two;
   private $three;
   [... many more fields ...]
}

      Source https://phpmd.org/rules/codesize.html#toomanyfields

      The method __construct has 18 parameters. Consider reducing the number of parameters to less than 10.
      Open

          public function __construct(
        $id,
        $name,
        $imageUrl,
        $isClaimed,
      Severity: Minor
      Found in src/FeedMeNow/Model/Restaurant.php by phpmd

      Avoid using static access to class '\FeedMeNow\Model\Hour' in method 'setHours'.
      Open

                  $return[] = Hour::create($hour);
      Severity: Minor
      Found in src/FeedMeNow/Model/Restaurant.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\FeedMeNow\Model\Category' in method 'setCategories'.
      Open

                  $return[] = Category::create($category);
      Severity: Minor
      Found in src/FeedMeNow/Model/Restaurant.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\FeedMeNow\Model\Provider' in method 'setProviders'.
      Open

                  $return[] = Provider::create($provider);
      Severity: Minor
      Found in src/FeedMeNow/Model/Restaurant.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid variables with short names like $id. Configured minimum length is 3.
      Open

          private $id;
      Severity: Minor
      Found in src/FeedMeNow/Model/Restaurant.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $id. Configured minimum length is 3.
      Open

              $id,
      Severity: Minor
      Found in src/FeedMeNow/Model/Restaurant.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      There are no issues that match your filters.

      Category
      Status