Sign upLogin

median-research-group/LibMTL

View on GitHub
Star
LibMTL/trainer.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function train has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Invalid

    def train(self, train_dataloaders, test_dataloaders, epochs, 
              val_dataloaders=None, return_weight=False):
        r'''The training process of multi-task learning.

        Args:
Severity: Minor
Found in LibMTL/trainer.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File trainer.py has 260 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import torch, os
import torch.nn as nn
import torch.nn.functional as F
import numpy as np
Severity: Minor
Found in LibMTL/trainer.py - About 2 hrs to fix

    Function __init__ has 12 arguments (exceeds 4 allowed). Consider refactoring.
    Invalid

        def __init__(self, task_dict, weighting, architecture, encoder_class, decoders,
    Severity: Major
    Found in LibMTL/trainer.py - About 1 hr to fix

      Function test has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def test(self, test_dataloaders, epoch=None, mode='test', return_improvement=False):
        r'''The test process of multi-task learning.

        Args:
            test_dataloaders (dict or torch.utils.data.DataLoader): If ``multi_input`` is ``True``, \
      Severity: Minor
      Found in LibMTL/trainer.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Invalid

                  def __init__(self, task_name, encoder_class, decoders, rep_grad, multi_input, device, kwargs):
      Severity: Major
      Found in LibMTL/trainer.py - About 50 mins to fix

        Function train has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def train(self, train_dataloaders, test_dataloaders, epochs,
        Severity: Minor
        Found in LibMTL/trainer.py - About 45 mins to fix

          Function test has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def test(self, test_dataloaders, epoch=None, mode='test', return_improvement=False):
          Severity: Minor
          Found in LibMTL/trainer.py - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Invalid

                            if not self.multi_input:
                    train_inputs, train_gts = self._process_data(train_loader)
                    train_preds = self.model(train_inputs)
                    train_preds = self.process_preds(train_preds)
                    train_losses = self._compute_loss(train_preds, train_gts)
            Severity: Major
            Found in LibMTL/trainer.py and 1 other location - About 2 hrs to fix
            LibMTL/trainer.py on lines 278..283

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Invalid

                            for batch_index in range(test_batch):
                    test_inputs, test_gts = self._process_data(test_loader)
                    test_preds = self.model(test_inputs)
                    test_preds = self.process_preds(test_preds)
                    test_losses = self._compute_loss(test_preds, test_gts)
            Severity: Major
            Found in LibMTL/trainer.py and 1 other location - About 2 hrs to fix
            LibMTL/trainer.py on lines 218..223

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status