Sign upLogin

medols/fresh

View on GitHub
Star
lib/fresh-mc.rb

Summary

Maintainability
D
2 days
Test Coverage

Class has too many lines. [223/150]
Open

class Fresh < BaseFresh 

  def argsapi call , *args
    sbuf =[*args[0]]
    hash = Hash===args[-1] && args[-1]
Severity: Minor
Found in lib/fresh-mc.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Class Fresh has 38 methods (exceeds 20 allowed). Consider refactoring.
Open

class Fresh < BaseFresh 

  def argsapi call , *args
    sbuf =[*args[0]]
    hash = Hash===args[-1] && args[-1]
Severity: Minor
Found in lib/fresh-mc.rb - About 5 hrs to fix

    File fresh-mc.rb has 365 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'rubinius/actor'

include Math

module Enumerable
    Severity: Minor
    Found in lib/fresh-mc.rb - About 4 hrs to fix

      Assignment Branch Condition size for argsapi is too high. [46.88/20]
      Open

        def argsapi call , *args
    sbuf =[*args[0]]
    hash = Hash===args[-1] && args[-1]
    rt   = args[2] ||
           ( call[/bcast|scatter|scatterv/] && hash && hash[:from]) ||
      Severity: Minor
      Found in lib/fresh-mc.rb by rubocop

      This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

      Assignment Branch Condition size for calldev is too high. [36.03/20]
      Open

          def calldev(*mult) 
      @@ret = [nil]*@@size
      @@exc = Array.new(@@size){[]}
      @@params=mult
      Severity: Minor
      Found in lib/fresh-mc.rb by rubocop

      This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

      Method argsapi has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

        def argsapi call , *args
    sbuf =[*args[0]]
    hash = Hash===args[-1] && args[-1]
    rt   = args[2] ||
           ( call[/bcast|scatter|scatterv/] && hash && hash[:from]) ||
      Severity: Minor
      Found in lib/fresh-mc.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method base_scatterv has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def base_scatterv scon , sdis , sbuf , rbuf , root , comm
      Severity: Minor
      Found in lib/fresh-mc.rb - About 45 mins to fix

        Method scatterv_lc has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def scatterv_lc scon , sdis , sbuf , rbuf , root , comm
        Severity: Minor
        Found in lib/fresh-mc.rb - About 45 mins to fix

          Method scatterv_tx has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def scatterv_tx scon , sdis , sbuf , root , comm
          Severity: Minor
          Found in lib/fresh-mc.rb - About 35 mins to fix

            Method base_scan has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              def base_scan op, sbuf , rbuf , rt , comm
            Severity: Minor
            Found in lib/fresh-mc.rb - About 35 mins to fix

              Method base_reduce_scatter has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def base_reduce_scatter op, sbuf , rbuf , rt , comm
              Severity: Minor
              Found in lib/fresh-mc.rb - About 35 mins to fix

                Method base_reduce has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  def base_reduce op, sbuf , rbuf , rt , comm
                Severity: Minor
                Found in lib/fresh-mc.rb - About 35 mins to fix

                  Method base_allreduce has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    def base_allreduce op, sbuf , rbuf , rt , comm
                  Severity: Minor
                  Found in lib/fresh-mc.rb - About 35 mins to fix

                    Avoid parameter lists longer than 5 parameters. [6/5]
                    Open

                      def base_scatterv scon , sdis , sbuf , rbuf , root , comm
                    Severity: Minor
                    Found in lib/fresh-mc.rb by rubocop

                    This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

                    Method calldev has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def calldev(*mult) 
      @@ret = [nil]*@@size
      @@exc = Array.new(@@size){[]}
      @@params=mult
                    Severity: Minor
                    Found in lib/fresh-mc.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid parameter lists longer than 5 parameters. [6/5]
                    Open

                      def scatterv_lc scon , sdis , sbuf , rbuf , root , comm
                    Severity: Minor
                    Found in lib/fresh-mc.rb by rubocop

                    This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        rt   = args[2] ||
           ( call[/bcast|scatter|scatterv/] && hash && hash[:from]) || 
           (!call[/bcast|scatter|scatterv/] && hash && hash[:to]) || 
           ( call[/allgather/] && all) || 
           root
                    Severity: Minor
                    Found in lib/fresh-mc.rb and 1 other location - About 30 mins to fix
                    lib/fresh-mc.rb on lines 271..276

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 33.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        comm = args[3] || 
           ( call[/bcast|scatter|scatterv/] && hash && hash[:to]) || 
           (!call[/bcast|scatter|scatterv/] && hash && hash[:from]) || 
           ( call[/sendrecv/] && root) || 
           all
                    Severity: Minor
                    Found in lib/fresh-mc.rb and 1 other location - About 30 mins to fix
                    lib/fresh-mc.rb on lines 266..271

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 33.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status