meilke/nunit-command

View on GitHub

Showing 9 of 9 total issues

Function createTeamcityLog has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

exports.createTeamcityLog = function(results) {

  var parser = sax.parser(true);
  var log = [];
  var ancestors = [];
Severity: Minor
Found in index.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildCommand has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

exports.buildCommand = function(assemblies, options) {

  var nunit = options.platform === 'x86' ? 'nunit-console-x86.exe' : 'nunit-console.exe';
  if (options.path) nunit = path.join(options.path, nunit);

Severity: Minor
Found in index.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createTeamcityLog has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.createTeamcityLog = function(results) {

  var parser = sax.parser(true);
  var log = [];
  var ancestors = [];
Severity: Major
Found in index.js - About 2 hrs to fix

    Function buildCommand has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.buildCommand = function(assemblies, options) {
    
      var nunit = options.platform === 'x86' ? 'nunit-console-x86.exe' : 'nunit-console.exe';
      if (options.path) nunit = path.join(options.path, nunit);
    
    
    Severity: Minor
    Found in index.js - About 1 hr to fix

      Function findTestAssemblies has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.findTestAssemblies = function(files, options) {
        var assemblies = [];
        var projects = [];
        files.forEach(function(file) {
          switch(path.extname(file)) {
      Severity: Minor
      Found in index.js - About 1 hr to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          if (options.exclude && options.exclude.length > 0) args.push('/exclude:"' + options.exclude.join(',') + '"');
        Severity: Major
        Found in index.js and 3 other locations - About 1 hr to fix
        index.js on lines 47..47
        index.js on lines 57..57
        index.js on lines 66..66

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          if (options.privatebinpath && options.privatebinpath.length > 0) args.push('/privatebinpath:"' + options.privatebinpath.join(';') + '"');
        Severity: Major
        Found in index.js and 3 other locations - About 1 hr to fix
        index.js on lines 47..47
        index.js on lines 57..57
        index.js on lines 58..58

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          if (options.run && options.run.length > 0) args.push('/run:"' + options.run.join(',') + '"');
        Severity: Major
        Found in index.js and 3 other locations - About 1 hr to fix
        index.js on lines 57..57
        index.js on lines 58..58
        index.js on lines 66..66

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          if (options.include && options.include.length > 0) args.push('/include:"' + options.include.join(',') + '"');
        Severity: Major
        Found in index.js and 3 other locations - About 1 hr to fix
        index.js on lines 47..47
        index.js on lines 58..58
        index.js on lines 66..66

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language