Sign upLogin

meissadia/tumblr_draftking

View on GitHub
Star
lib/draftking/client.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method act_on_blog has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def act_on_blog(name: nil)
      return unless connected?
      @user = client_user_info_to_ostruct
      @blog_name = name ? name.gsub('.tumblr.com', '') : @user.blogs.first.name
      @blog_url  = tumblr_url(@blog_name)
Severity: Minor
Found in lib/draftking/client.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_source has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def process_source(src)
      return :draft unless src
      return src if src.is_a? Symbol
      return :dashboard if src.include?('dash')
      return :queue if src.include?('queue')
Severity: Minor
Found in lib/draftking/client.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return :posts if src.include?('publish')
Severity: Major
Found in lib/draftking/client.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return :draft if src.include?('draft')
    Severity: Major
    Found in lib/draftking/client.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status