Sign upLogin

meissadia/tumblr_draftking

View on GitHub
Star
lib/draftking/posts/post.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method save has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def save(client:, simulate: nil)
      return 0 unless @changed
      return @saved = 1 if simulate
      retries = 0
      begin
Severity: Minor
Found in lib/draftking/posts/post.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate_tags has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def generate_tags(keep_tags: nil, add_tags: nil, exclude: nil, credit: false)
      tags  = comment_to_tags(@comment)
      tags += csv_to_a(add_tags)    if add_tags
      tags += @tags                 if keep_tags
      tags << DK::CREDIT_TAG        if credit
Severity: Minor
Found in lib/draftking/posts/post.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method reblog has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def reblog(client:, simulate: nil)
      return 1 if simulate
      retries = 0
      begin
        client.reblog @blog_url,
Severity: Minor
Found in lib/draftking/posts/post.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status