Sign upLogin

mekanika/query

View on GitHub
Star

Showing 7 of 7 total issues

Function _mo has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

var _mo = function (boolop, field, val) {
  // Creates a new `.match` field if needed
  if (!this.qe.match) this.qe.match = new MatchContainer(boolop);

  if (typeof field === 'string') {
Severity: Minor
Found in lib/proto/match.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function populate has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

exports.populate = function (field) {
  if (!this.qe.on) {
    throw new Error('Query#populate(field) requires .on to be set');
  }
Severity: Minor
Found in lib/proto/populate.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function posthook has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

exports.posthook = function (post, cb, qe) {
  return function (e, r) {
    var runPost = function (i, err, res) {
      i || (i = 0);
Severity: Minor
Found in lib/proto/actions.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function mixin has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function mixin (target, loc) {
  if (!target) throw new Error('Must specify target');

  // Protects scope
  var each = function (arr, fn) {
Severity: Minor
Found in lib/match/operators.js - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    var _renameSoloKey = function (obj, newKey) {
  var oldkey = Object.keys(obj)[0];
  obj[ newKey ] = obj[ oldkey ];
  delete obj[ oldkey ];
};
    Severity: Major
    Found in lib/match/MatchContainer.js and 1 other location - About 1 hr to fix
    lib/match/operators.js on lines 63..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          var _renameSoloKey = function (obj, newKey) {
        var oldkey = Object.keys(obj)[0];
        obj[ newKey ] = obj[ oldkey ];
        delete obj[ oldkey ];
      };
    Severity: Major
    Found in lib/match/operators.js and 1 other location - About 1 hr to fix
    lib/match/MatchContainer.js on lines 28..32

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function done has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.done = function (cb) {
  // Shorthand
  var qe = this.qe;
  var hooks = this.middleware;
    Severity: Minor
    Found in lib/proto/actions.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language