Sign upLogin

melphi/algobox

View on GitHub
Star
java/algobox/algobox-core/src/main/java/io/algobox/backtest/ExperimentOrderService.java

Summary

Maintainability
A
2 hrs
Test Coverage

Method onPriceTick has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  @Override
  public synchronized void onPriceTick(String source, PriceTick priceTick) {
    List<Order> filledOrders = Lists.newArrayList();
    List<Order> cancelledOrders = Lists.newArrayList();
    for (Order order: activeOrders) {
Severity: Minor
Found in java/algobox/algobox-core/src/main/java/io/algobox/backtest/ExperimentOrderService.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method updateTradesStatus has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  private void updateTradesStatus(PriceTick priceTick) {
    List<Trade> closingTrades = Lists.newArrayList();
    for (int i = 0; i < activeTrades.size(); i++) {
      Trade trade = activeTrades.get(i);
      if (priceTick.getInstrument().equals(trade.getInstrumentId()) &&
Severity: Minor
Found in java/algobox/algobox-core/src/main/java/io/algobox/backtest/ExperimentOrderService.java - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

  // TODO: Do some microbenchmark, this method could be a bottleneck.
Severity: Minor
Found in java/algobox/algobox-core/src/main/java/io/algobox/backtest/ExperimentOrderService.java by fixme

TODO found
Open

  // TODO: Tune the initial size of the array lists.
Severity: Minor
Found in java/algobox/algobox-core/src/main/java/io/algobox/backtest/ExperimentOrderService.java by fixme

There are no issues that match your filters.

Category
Status