Sign upLogin

mender/protein

View on GitHub
Star
lib/protein/worker/collection.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class CollectionItem has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

    class CollectionItem
      delegate :config, :logger, :redis, :to => :Protein
      attr_reader :collection

      def self.dummy
Severity: Minor
Found in lib/protein/worker/collection.rb - About 2 hrs to fix

    File collection.rb has 271 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'protein/worker/lock'
require 'protein/uuid'

module Protein
  class Worker
    Severity: Minor
    Found in lib/protein/worker/collection.rb - About 2 hrs to fix

      Method release_lock has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def release_lock
        yield_result = block_given? ? yield : nil
        lock_result = lock.release
        block_given? ? yield_result : lock_result
      rescue => e
      Severity: Minor
      Found in lib/protein/worker/collection.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_lock has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def get_lock
        lock.acquire do |id|
          # TODO избавиться
          # если дождались свободного места в пуле,
          # но во время ожидания пришла команда на остановку процесса
      Severity: Minor
      Found in lib/protein/worker/collection.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status