Sign upLogin

menglifang/task-manager

View on GitHub
Star

Showing 47 of 47 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        def index
          tasks = TaskManager::Task.page(params[:page]).per(params[:limit]).
            order('id DESC').search(params[:q]).result
          result = {
            total: tasks.total_count,
Severity: Minor
Found in app/controllers/task_manager/api/v1/tasks_controller.rb and 1 other location - About 40 mins to fix
app/controllers/task_manager/api/v1/plans_controller.rb on lines 49..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function renderer has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    renderer: function(value, metadata, record, rowIdx, colIdx) {
Severity: Minor
Found in app/assets/javascripts/task-manager/extjs/lib/ux/RowExpander.js - About 35 mins to fix

    Function onDblClick has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        onDblClick: function(view, cell, rowIdx, cellIndex, e) {
    Severity: Minor
    Found in app/assets/javascripts/task-manager/extjs/lib/ux/RowExpander.js - About 35 mins to fix

      Function setValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          setValue: function(valueInit)
    {
        if(typeof valueInit == 'undefined') return;
        
        var    me = this,
      Severity: Minor
      Found in app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          Ext.each(me.records, function(record)
                    {
                        values.push(record.get(me.valueField));
                    });
      Severity: Minor
      Found in app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js and 1 other location - About 30 mins to fix
      app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js on lines 165..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              Ext.each(me.records, function(value)
        {
            ids.push(value.get(me.valueField));
        });
      Severity: Minor
      Found in app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js and 1 other location - About 30 mins to fix
      app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js on lines 251..254

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function bindView has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          bindView: function() {
        var view = this.getCmp().getView(),
            viewEl;

        if (!view.rendered) {
      Severity: Minor
      Found in app/assets/javascripts/task-manager/extjs/lib/ux/RowExpander.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language