Sign upLogin

mesg-foundation/core

View on GitHub
Star
cosmos/lcd.go

Summary

Maintainability
A
1 hr
Test Coverage

Method LCD.BroadcastMsgs has 7 return statements (exceeds 6 allowed).
Open

func (lcd *LCD) BroadcastMsgs(msgs []sdk.Msg) ([]byte, error) {
    // Lock the getAccount + create and sign tx + broadcast
    lcd.broadcastMutex.Lock()
    defer lcd.broadcastMutex.Unlock()
Severity: Major
Found in cosmos/lcd.go - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (lcd *LCD) setAccountSequence(seq uint64) error {
    lcd.accountMutex.Lock()
    defer lcd.accountMutex.Unlock()
    if lcd.acc == nil {
        return fmt.Errorf("lcd.acc should not be nil. use getAccount first")
    Severity: Minor
    Found in cosmos/lcd.go and 1 other location - About 30 mins to fix
    cosmos/rpc.go on lines 193..200

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    package cosmos
    Severity: Minor
    Found in cosmos/lcd.go by gofmt

    There are no issues that match your filters.

    Category
    Status