mesg-foundation/core

View on GitHub
e2e/testdata/test-service/main.go

Summary

Maintainability
C
7 hrs
Test Coverage

Function processExec has 77 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func processExec(client runner.RunnerClient, token string, exec *execution.Execution) {
    var outputs *types.Struct
    if exec.TaskKey == "task_trigger" || exec.TaskKey == "task1" || exec.TaskKey == "task2" {
        outputs = &types.Struct{
            Fields: map[string]*types.Value{
Severity: Major
Found in e2e/testdata/test-service/main.go - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    func register() (string, error) {
        endpoint := os.Getenv(envMesgEndpoint)
        if endpoint == "" {
            return "", fmt.Errorf("env %q is empty", envMesgEndpoint)
        }
    Severity: Major
    Found in e2e/testdata/test-service/main.go and 1 other location - About 3 hrs to fix
    e2e/testdata/test-complex-service/main.go on lines 29..59

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 276.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    func newClient(token string) (runner.RunnerClient, error) {
        endpoint := os.Getenv(envMesgEndpoint)
        if endpoint == "" {
            return nil, fmt.Errorf("env %q is empty", envMesgEndpoint)
        }
    Severity: Major
    Found in e2e/testdata/test-service/main.go and 1 other location - About 1 hr to fix
    e2e/testdata/test-complex-service/main.go on lines 61..83

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 187.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status