Sign upLogin

metamaps/metamaps

View on GitHub
Star
app/controllers/mappings_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage

index is not explicitly defined on the controller.
Open

  after_action :verify_policy_scoped, only: :index
Severity: Minor
Found in app/controllers/mappings_controller.rb by rubocop

This cop checks that methods specified in the filter's only or except options are explicitly defined in the controller.

You can specify methods of superclass or methods added by mixins on the filter, but these confuse developers. If you specify methods where are defined on another controller, you should define the filter in that controller.

Example:

# bad
class LoginController < ApplicationController
  before_action :require_login, only: %i[index settings logout]

  def index
  end
end

# good
class LoginController < ApplicationController
  before_action :require_login, only: %i[index settings logout]

  def index
  end

  def settings
  end

  def logout
  end
end

index is not explicitly defined on the controller.
Open

  after_action :verify_authorized, except: :index
Severity: Minor
Found in app/controllers/mappings_controller.rb by rubocop

This cop checks that methods specified in the filter's only or except options are explicitly defined in the controller.

You can specify methods of superclass or methods added by mixins on the filter, but these confuse developers. If you specify methods where are defined on another controller, you should define the filter in that controller.

Example:

# bad
class LoginController < ApplicationController
  before_action :require_login, only: %i[index settings logout]

  def index
  end
end

# good
class LoginController < ApplicationController
  before_action :require_login, only: %i[index settings logout]

  def index
  end

  def settings
  end

  def logout
  end
end

There are no issues that match your filters.

Category
Status