Sign upLogin

metamaps/metamaps

View on GitHub
Star
app/helpers/synapses_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage

Method has too many lines. [12/10]
Open

  def autocomplete_synapse_array_json(synapses)
    synapses.map do |s|
      {
        id: s.id,
        label: s.desc.blank? ? '(no description)' : s.desc,
Severity: Minor
Found in app/helpers/synapses_helper.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Use s.desc.presence || '(no description)' instead of s.desc.blank? ? '(no description)' : s.desc.
Open

        label: s.desc.blank? ? '(no description)' : s.desc,
Severity: Minor
Found in app/helpers/synapses_helper.rb by rubocop

This cop checks code that can be written more easily using Object#presence defined by Active Support.

Example:

# bad
a.present? ? a : nil

# bad
!a.present? ? nil : a

# bad
a.blank? ? nil : a

# bad
!a.blank? ? a : nil

# good
a.presence

Example:

# bad
a.present? ? a : b

# bad
!a.present? ? b : a

# bad
a.blank? ? b : a

# bad
!a.blank? ? a : b

# good
a.presence || b

There are no issues that match your filters.

Category
Status