metaminded/tabulatr2

View on GitHub

Showing 626 of 626 total issues

Use the new Ruby 1.9 hash syntax.
Open

        :count => pagination[:count],
Severity: Minor
Found in lib/tabulatr/data/data.rb by rubocop

This cop checks hash literal syntax.

It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

A separate offense is registered for each problematic pair.

The supported styles are:

  • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
  • hash_rockets - forces use of hash rockets for all hashes
  • nomixedkeys - simply checks for hashes with mixed syntaxes
  • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

Example: EnforcedStyle: ruby19 (default)

# bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

Example: EnforcedStyle: hash_rockets

# bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

Example: EnforcedStyle: nomixedkeys

# bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

Example: EnforcedStyle: ruby19nomixed_keys

# bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

    if tabulatr_checked.present?
Severity: Minor
Found in lib/tabulatr/data/data.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Add parentheses to nested method call filter_params params.
Open

    apply_filters(filter_params params)
Severity: Minor
Found in lib/tabulatr/data/data.rb by rubocop

This cop checks for unparenthesized method calls in the argument list of a parenthesized method call.

Example:

# good
method1(method2(arg), method3(arg))

# bad
method1(method2 arg, method3, arg)

Line is too long. [81/80]
Open

    return batch_result if batch_result.is_a? Tabulatr::Responses::DirectResponse
Severity: Minor
Found in lib/tabulatr/data/data.rb by rubocop

unexpected token tRPAREN (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

    filters = default_filters.merge(filter_params&.permit! || {})
Severity: Minor
Found in lib/tabulatr/data/filtering.rb by rubocop

unexpected token kDO_BLOCK (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

    filters.to_hash.with_indifferent_access.each do |param|
Severity: Minor
Found in lib/tabulatr/data/filtering.rb by rubocop
Severity
Category
Status
Source
Language