metaminded/tabulatr2

View on GitHub
lib/tabulatr/data/pagination.rb

Summary

Maintainability
A
0 mins
Test Coverage

Method has too many lines. [13/10]
Open

  def compute_pagination(page, pagesize)
    count = @relation.count
    count = count.count if count.is_a?(Hash)
    page ||= 1
    pagesize, page = pagesize.to_i, page.to_i
Severity: Minor
Found in lib/tabulatr/data/pagination.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for compute_pagination is too high. [16.76/15]
Open

  def compute_pagination(page, pagesize)
    count = @relation.count
    count = count.count if count.is_a?(Hash)
    page ||= 1
    pagesize, page = pagesize.to_i, page.to_i
Severity: Minor
Found in lib/tabulatr/data/pagination.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Do not use :: for method calls.
Open

    pagesize = Tabulatr::pagesize if pagesize == 0
Severity: Minor
Found in lib/tabulatr/data/pagination.rb by rubocop

This cop checks for methods invoked via the :: operator instead of the . operator (like FileUtils::rmdir instead of FileUtils.rmdir).

Example:

# bad
Timeout::timeout(500) { do_something }
FileUtils::rmdir(dir)
Marshal::dump(obj)

# good
Timeout.timeout(500) { do_something }
FileUtils.rmdir(dir)
Marshal.dump(obj)

Surrounding space missing for operator /.
Open

    pages = (count/pagesize.to_f).ceil
Severity: Minor
Found in lib/tabulatr/data/pagination.rb by rubocop

Checks that operators have space around them, except for ** which should not have surrounding space.

Example:

# bad
total = 3*4
"apple"+"juice"
my_number = 38/4
a ** b

# good
total = 3 * 4
"apple" + "juice"
my_number = 38 / 4
a**b

Do not use parallel assignment.
Open

    pagesize, page = pagesize.to_i, page.to_i
Severity: Minor
Found in lib/tabulatr/data/pagination.rb by rubocop

Checks for simple usages of parallel assignment. This will only complain when the number of variables being assigned matched the number of assigning variables.

Example:

# bad
a, b, c = 1, 2, 3
a, b, c = [1, 2, 3]

# good
one, two = *foo
a, b = foo()
a, b = b, a

a = 1
b = 2
c = 3

Surrounding space missing for operator *.
Open

      offset: [0,((page-1)*pagesize).to_i].max,
Severity: Minor
Found in lib/tabulatr/data/pagination.rb by rubocop

Checks that operators have space around them, except for ** which should not have surrounding space.

Example:

# bad
total = 3*4
"apple"+"juice"
my_number = 38/4
a ** b

# good
total = 3 * 4
"apple" + "juice"
my_number = 38 / 4
a**b

Use nested module/class definitions instead of compact style.
Open

module Tabulatr::Data::Pagination
Severity: Minor
Found in lib/tabulatr/data/pagination.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Use pagesize.zero? instead of pagesize == 0.
Open

    pagesize = Tabulatr::pagesize if pagesize == 0
Severity: Minor
Found in lib/tabulatr/data/pagination.rb by rubocop

This cop checks for usage of comparison operators (==, >, <) to test numbers as zero, positive, or negative. These can be replaced by their respective predicate methods. The cop can also be configured to do the reverse.

The cop disregards #nonzero? as it its value is truthy or falsey, but not true and false, and thus not always interchangeable with != 0.

The cop ignores comparisons to global variables, since they are often populated with objects which can be compared with integers, but are not themselves Interger polymorphic.

Example: EnforcedStyle: predicate (default)

# bad

foo == 0
0 > foo
bar.baz > 0

# good

foo.zero?
foo.negative?
bar.baz.positive?

Example: EnforcedStyle: comparison

# bad

foo.zero?
foo.negative?
bar.baz.positive?

# good

foo == 0
0 > foo
bar.baz > 0

Space missing after comma.
Open

      offset: [0,((page-1)*pagesize).to_i].max,
Severity: Minor
Found in lib/tabulatr/data/pagination.rb by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Surrounding space missing for operator -.
Open

      offset: [0,((page-1)*pagesize).to_i].max,
Severity: Minor
Found in lib/tabulatr/data/pagination.rb by rubocop

Checks that operators have space around them, except for ** which should not have surrounding space.

Example:

# bad
total = 3*4
"apple"+"juice"
my_number = 38/4
a ** b

# good
total = 3 * 4
"apple" + "juice"
my_number = 38 / 4
a**b

Missing top-level module documentation comment.
Open

module Tabulatr::Data::Pagination
Severity: Minor
Found in lib/tabulatr/data/pagination.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Extra empty line detected at module body beginning.
Open


  def apply_pagination(offset: 0, pagesize: nil)
Severity: Minor
Found in lib/tabulatr/data/pagination.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

There are no issues that match your filters.

Category
Status