metaminded/tabulatr2

View on GitHub
lib/tabulatr/rails/action_view.rb

Summary

Maintainability
A
0 mins
Test Coverage

Avoid parameter lists longer than 5 parameters. [6/5]
Open

  def table_for(klass, columns: [], filters: [], tabulatr_data_class: nil, **opts, &block)
Severity: Minor
Found in lib/tabulatr/rails/action_view.rb by rubocop

This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

Line is too long. [100/80]
Open

    Tabulatr::Renderer.build_table(klass, self, opts, columns, filters, tabulatr_data_class, &block)
Severity: Minor
Found in lib/tabulatr/rails/action_view.rb by rubocop

Use nested module/class definitions instead of compact style.
Open

class ActionView::Base
Severity: Minor
Found in lib/tabulatr/rails/action_view.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Surrounding space missing in default value assignment.
Open

  def static_table_for(records, opts={}, &block)
Severity: Minor
Found in lib/tabulatr/rails/action_view.rb by rubocop

Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

Example:

# bad
def some_method(arg1=:default, arg2=nil, arg3=[])
  # do something...
end

# good
def some_method(arg1 = :default, arg2 = nil, arg3 = [])
  # do something...
end

Missing top-level class documentation comment.
Open

class ActionView::Base
Severity: Minor
Found in lib/tabulatr/rails/action_view.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [90/80]
Open

  def table_for(klass, columns: [], filters: [], tabulatr_data_class: nil, **opts, &block)
Severity: Minor
Found in lib/tabulatr/rails/action_view.rb by rubocop

There are no issues that match your filters.

Category
Status