metanorma/metanorma-iso

View on GitHub

Showing 33 of 43 total issues

Method make_tr_attr has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def make_tr_attr(cell, row, totalrows, header, bordered)
Severity: Minor
Found in lib/isodoc/iso/word_dis_convert.rb - About 35 mins to fix

    Method style_two_regex_not_prev has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def style_two_regex_not_prev(n, text, regex, re_prev, warning)
    Severity: Minor
    Found in lib/metanorma/iso/validate_style.rb - About 35 mins to fix

      Method clause_etc1 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def clause_etc1(clause, out, num)
              out.div **attr_code(
                id: clause["id"],
                class: clause.name == "definitions" ? "Symbols" : nil,
              ) do |div|
      Severity: Minor
      Found in lib/isodoc/iso/base_convert.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method style_two_regex_not_prev has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def style_two_regex_not_prev(n, text, regex, re_prev, warning)
              return if text.nil?
      
              arr = Tokenizer::WhitespaceTokenizer.new.tokenize(text)
              arr.each_index do |i|
      Severity: Minor
      Found in lib/metanorma/iso/validate_style.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method ol_depth has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def ol_depth(node)
              depth = node.ancestors(@iso_class ? "ol" : "ul, ol").size + 1
              type = :alphabet
              type = :arabic if [2, 7].include? depth
              type = :roman if [3, 8].include? depth
      Severity: Minor
      Found in lib/isodoc/iso/presentation_xml_convert.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method vocab_terms_titles_validate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def vocab_terms_titles_validate(root)
              terms = root.xpath("//sections/terms | //sections/clause[.//terms]")
              if terms.size == 1
                ((t = terms.first.at("./title")) && (t&.text == @i18n.termsdef)) or
                  @log.add("Style", terms.first,
      Severity: Minor
      Found in lib/metanorma/iso/validate_section.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method image_name_validate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def image_name_validate(xmldoc)
              prefix = image_name_prefix(xmldoc) or return
              xmldoc.xpath("//image").each do |i|
                next if i["src"].start_with?("data:")
      
      
      Severity: Minor
      Found in lib/metanorma/iso/validate_image.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method figure_parse1 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def figure_parse1(node, out)
              measurement_units(node, out)
              out.div **figure_attrs(node) do |div|
                node.children.each do |n|
                  n.name == "note" && n["type"] == "units" and next
      Severity: Minor
      Found in lib/isodoc/iso/base_convert.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method isosubgroup_validate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def isosubgroup_validate(root)
              root.xpath("//technical-committee/@type").each do |t|
                unless %w{TC PC JTC JPC}.include? t.text
                  @log.add("Document Attributes", nil,
                           "invalid technical committee type #{t}")
      Severity: Minor
      Found in lib/metanorma/iso/validate.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method style_list_iso has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def style_list_iso(elem, level, listtype, idx)
            return idx if elem.at(".//ol | .//ul") && !elem.at("./p")
      
            idx += 1
            ol = elem.xpath("./ancestor::ol")&.last
      Severity: Minor
      Found in lib/html2doc/lists.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method note_continued_style has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def note_continued_style(docxml)
              docxml.xpath("//div[@class = 'Note']").each do |d|
                d.xpath("./p").each_with_index do |p, i|
                  p["class"] && p["class"] != "Note" and next
                  p["class"] = (i.zero? ? "Note" : "Notecontinued")
      Severity: Minor
      Found in lib/isodoc/iso/word_dis_styles.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method xrefs_mandate_validate1 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def xrefs_mandate_validate1(xmldoc, xpath, name)
              exc = %w(table note example figure).map { |x| "//#{x}#{xpath}" }
                .join(" | ")
              (xmldoc.xpath(xpath) - xmldoc.xpath(exc)).each do |x|
                x["unnumbered"] == "true" and next
      Severity: Minor
      Found in lib/metanorma/iso/validate.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method example_continued_style has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def example_continued_style(docxml)
              docxml.xpath("//div[@class = 'Example']").each do |d|
                d.xpath("./p").each_with_index do |p, i|
                  p["class"] && p["class"] != "Example" and next
                  p["class"] = (i.zero? ? "Example" : "Examplecontinued")
      Severity: Minor
      Found in lib/isodoc/iso/word_dis_styles.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language