Sign upLogin

meteor/meteor

View on GitHub
Star
npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift

Summary

Maintainability
C
1 day
Test Coverage

Function addBlacklistedVersion has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  func addBlacklistedVersion(_ version: String) {
    var blacklistedVersions = self.blacklistedVersions
    var versionsToRetry = self.versionsToRetry
    
    if (!versionsToRetry.contains(version) && !blacklistedVersions.contains(version)) {
Severity: Minor
Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  var versionsToRetry: [String] {
    get {
      let versions = userDefaults.array(forKey: "MeteorWebAppVersionsToRetry") as? [String] ?? []
      NSLog("BLACKLIST - versionsToRetry: \(versions)")
      return versions
Severity: Major
Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift and 1 other location - About 1 hr to fix
npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift on lines 114..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  var blacklistedVersions: [String] {
    get {
      let versions = userDefaults.array(forKey: "MeteorWebAppBlacklistedVersions") as? [String] ?? []
      NSLog("BLACKLIST - blacklistedVersions: \(versions)")
      return versions
Severity: Major
Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift and 1 other location - About 1 hr to fix
npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift on lines 134..151

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  var appId: String? {
    get {
      return userDefaults.string(forKey: "MeteorWebAppId")
    }
    set {
Severity: Major
Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift and 1 other location - About 1 hr to fix
npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift on lines 23..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  var rootURL: URL? {
    get {
      return userDefaults.url(forKey: "MeteorWebAppRootURL")
    }
    set {
Severity: Major
Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift and 1 other location - About 1 hr to fix
npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift on lines 5..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  var lastSeenInitialVersion: String? {
    get {
      return userDefaults.string(forKey: "MeteorWebAppLastSeenInitialVersion")
    }
Severity: Major
Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift and 2 other locations - About 1 hr to fix
npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift on lines 41..56
npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift on lines 77..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  var cordovaCompatibilityVersion: String? {
    get {
      return userDefaults.string(forKey: "MeteorWebAppCordovaCompatibilityVersion")
    }
Severity: Major
Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift and 2 other locations - About 1 hr to fix
npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift on lines 59..74
npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift on lines 77..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  var lastDownloadedVersion: String? {
    get {
      return userDefaults.string(forKey: "MeteorWebAppLastDownloadedVersion")
    }
Severity: Major
Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift and 2 other locations - About 1 hr to fix
npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift on lines 41..56
npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppConfiguration.swift on lines 59..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status