Sign upLogin

meteor/meteor

View on GitHub
Star
npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift

Summary

Maintainability
D
3 days
Test Coverage

File WebAppLocalServer.swift has 360 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import WebKit

let oneYearInSeconds = 60 * 60 * 24 * 365

let GCDWebServerRequestAttribute_Asset = "GCDWebServerRequestAttribute_Asset"
Severity: Minor
Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 4 hrs to fix

    WebAppLocalServer has 26 methods (exceeds 20 allowed). Consider refactoring.
    Open

    @objc(METWebAppLocalServer)
open class WebAppLocalServer: METPlugin, AssetBundleManagerDelegate {
  /// The local web server responsible for serving assets to the web app
  private(set) var localServer: GCDWebServer!
    Severity: Minor
    Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 3 hrs to fix

      Function initializeAssetBundles has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        func initializeAssetBundles() {
    assetBundleManager = nil;

    // The initial asset bundle consists of the assets bundled with the app
    let initialAssetBundle: AssetBundle
      Severity: Minor
      Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 1 hr to fix

        Function initializeAssetBundles has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          func initializeAssetBundles() {
    assetBundleManager = nil;

    // The initial asset bundle consists of the assets bundled with the app
    let initialAssetBundle: AssetBundle
        Severity: Minor
        Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function pluginInitialize has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          override open func pluginInitialize() {
    super.pluginInitialize()

    // Detect whether we are testing the app using
    // cordova-plugin-test-framework
        Severity: Minor
        Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 1 hr to fix

          Function responseForFile has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            private func responseForFile(_ request: GCDWebServerRequest, filePath: String, cacheable: Bool, hash: String? = nil, sourceMapURLPath: String? = nil) -> GCDWebServerResponse {
    // To protect our server from access by other apps running on the same device,
    // we check whether the rponsequest contains an auth token.
    // The auth token can be passed either as a query item or as a cookie.
    // If the auth token was passed as a query item, we set the cookie.
          Severity: Minor
          Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function responseForFile has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            private func responseForFile(_ request: GCDWebServerRequest, filePath: String, cacheable: Bool, hash: String? = nil, sourceMapURLPath: String? = nil) -> GCDWebServerResponse {
    // To protect our server from access by other apps running on the same device,
    // we check whether the rponsequest contains an auth token.
    // The auth token can be passed either as a query item or as a cookie.
    // If the auth token was passed as a query item, we set the cookie.
          Severity: Minor
          Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 1 hr to fix

            Function addHandlerForWwwDirectory has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              private func addHandlerForWwwDirectory() {
    localServer.addHandler(match: { [weak self] (requestMethod, requestURL, requestHeaders, urlPath, urlQuery) -> GCDWebServerRequest? in
      if requestMethod != "GET" { return nil }

      // Do not serve files from /application, because these should only be served through the initial asset bundle
            Severity: Minor
            Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function addIndexFileHandler has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              private func addIndexFileHandler() {
    localServer.addHandler(match: { [weak self] (requestMethod, requestURL, requestHeaders, urlPath, urlQuery) -> GCDWebServerRequest? in
      if requestMethod != "GET" { return nil }

      // Don't serve index.html for local file system paths
            Severity: Minor
            Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function responseForFile has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              private func responseForFile(_ request: GCDWebServerRequest, filePath: String, cacheable: Bool, hash: String? = nil, sourceMapURLPath: String? = nil) -> GCDWebServerResponse {
            Severity: Minor
            Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 35 mins to fix

              Avoid too many return statements within this function.
              Open

                      return self.responseForAsset(request, asset: asset)
              Severity: Major
              Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return self.responseForFile(request, filePath: filePath, cacheable: false)
                Severity: Major
                Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return request
                  Severity: Major
                  Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return request
                    Severity: Major
                    Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return self.responseForFile(request, filePath: filePath, cacheable: false)
                      Severity: Major
                      Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 30 mins to fix

                        Function pluginInitialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                          override open func pluginInitialize() {
    super.pluginInitialize()

    // Detect whether we are testing the app using
    // cordova-plugin-test-framework
                        Severity: Minor
                        Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function addHandlerForLocalFileSystem has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                          private func addHandlerForLocalFileSystem() {
    localServer.addHandler(match: { (requestMethod, requestURL, requestHeaders, urlPath, urlQuery) -> GCDWebServerRequest? in
      if requestMethod != "GET" { return nil }

      if !(urlPath.hasPrefix(localFileSystemPath)) { return nil }
                        Severity: Minor
                        Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                          @objc open func onNewVersionReady(_ command: CDVInvokedUrlCommand) {
    newVersionReadyCallbackId = command.callbackId

    let result = CDVPluginResult(status: CDVCommandStatus_NO_RESULT)
    // This allows us to invoke the callback later
                        Severity: Minor
                        Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift and 1 other location - About 50 mins to fix
                        npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift on lines 297..304

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 62.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                          @objc open func onError(_ command: CDVInvokedUrlCommand) {
    errorCallbackId = command.callbackId

    let result = CDVPluginResult(status: CDVCommandStatus_NO_RESULT)
    // This allows us to invoke the callback later
                        Severity: Minor
                        Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift and 1 other location - About 50 mins to fix
                        npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift on lines 279..286

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 62.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            localServer.addHandler(match: { (requestMethod, requestURL, requestHeaders, urlPath, urlQuery) -> GCDWebServerRequest? in
      if requestMethod != "GET" { return nil }

      if !(urlPath.hasPrefix(localFileSystemPath)) { return nil }
                        Severity: Minor
                        Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift and 1 other location - About 40 mins to fix
                        npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift on lines 430..445

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 51.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            localServer.addHandler(match: { [weak self] (requestMethod, requestURL, requestHeaders, urlPath, urlQuery) -> GCDWebServerRequest? in
      if requestMethod != "GET" { return nil }

      // Do not serve files from /application, because these should only be served through the initial asset bundle
      if (urlPath.hasPrefix("/application")) { return nil }
                        Severity: Minor
                        Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift and 1 other location - About 40 mins to fix
                        npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift on lines 449..464

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 51.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            localServer.addHandler(match: { [weak self] (requestMethod, requestURL, requestHeaders, urlPath, urlQuery) -> GCDWebServerRequest? in
      if requestMethod != "GET" { return nil }

      // Don't serve index.html for local file system paths
      if (urlPath.hasPrefix(localFileSystemPath)) { return nil }
                        Severity: Minor
                        Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift and 1 other location - About 40 mins to fix
                        npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift on lines 416..426

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 48.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            localServer.addHandler(match: { [weak self] (requestMethod, requestURL, requestHeaders, urlPath, urlQuery) -> GCDWebServerRequest? in
      if requestMethod != "GET" { return nil }
      guard let asset = self?.currentAssetBundle?.assetForURLPath(urlPath) else { return nil }

      let request = GCDWebServerRequest(method: requestMethod, url: requestURL, headers: requestHeaders, path: urlPath, query: urlQuery)
                        Severity: Minor
                        Found in npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift and 1 other location - About 40 mins to fix
                        npm-packages/cordova-plugin-meteor-webapp/src/ios/WebAppLocalServer.swift on lines 468..484

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 48.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status