Sign upLogin

meteor/meteor

View on GitHub
Star
tools/isobuild/resolver.ts

Summary

Maintainability
D
2 days
Test Coverage

Function resolve has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

  public resolve(
    id: string,
    absParentPath: string,
    _seenDirPaths?: Set<string>,
  ): Resolution {
Severity: Minor
Found in tools/isobuild/resolver.ts - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File resolver.ts has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  isString,
  isObject,
  has,
} from "underscore";
Severity: Minor
Found in tools/isobuild/resolver.ts - About 3 hrs to fix

    Function resolve has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public resolve(
    id: string,
    absParentPath: string,
    _seenDirPaths?: Set<string>,
  ): Resolution {
    Severity: Major
    Found in tools/isobuild/resolver.ts - About 2 hrs to fix

      Function resolveNodeModule has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

        private resolveNodeModule(id: string, absParentPath: string): Resolution {
    if (! Resolver.isTopLevel(id)) {
      return null;
    }
      Severity: Minor
      Found in tools/isobuild/resolver.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function resolveNodeModule has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private resolveNodeModule(id: string, absParentPath: string): Resolution {
    if (! Resolver.isTopLevel(id)) {
      return null;
    }
      Severity: Minor
      Found in tools/isobuild/resolver.ts - About 1 hr to fix

        Function constructor has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          constructor({
    sourceRoot,
    targetArch,
    extensions = [".js", ".json"],
    nodeModulesPaths = [],
        Severity: Minor
        Found in tools/isobuild/resolver.ts - About 1 hr to fix

          Function findPkgJsonSubsetForPath has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            private findPkgJsonSubsetForPath(
    path: string,
  ): ReturnType<Resolver["getPkgJsonSubsetForDir"]> {
    const stat = this.statOrNull(path);
          Severity: Minor
          Found in tools/isobuild/resolver.ts - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

              return this.findPkgJsonSubsetForPath(parentDir);
          Severity: Major
          Found in tools/isobuild/resolver.ts - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status