Sign upLogin

meteor/meteor

View on GitHub
Star
tools/utils/parse-stack.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function parseStackFrames has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function parseStackFrames(frames: string[]): ParsedStackFrame[] {
  let stop = false;
  let parsedFrames: ParsedStackFrame[] = [];

  frames.some(frame => {
Severity: Minor
Found in tools/utils/parse-stack.ts - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

          return stop = true;
    Severity: Major
    Found in tools/utils/parse-stack.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return;
      Severity: Major
      Found in tools/utils/parse-stack.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return stop = true;
        Severity: Major
        Found in tools/utils/parse-stack.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return;
          Severity: Major
          Found in tools/utils/parse-stack.ts - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            export function markBottom(f: Function, context: any) {
  /* eslint-disable camelcase */
  return function __bottom_mark__() {
    // @ts-ignore: Implicit this
    return f.apply(context || this, arguments);
            Severity: Minor
            Found in tools/utils/parse-stack.ts and 1 other location - About 55 mins to fix
            tools/utils/parse-stack.ts on lines 105..112

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            export function markTop(f: Function, context: any) {
  /* eslint-disable camelcase */
  return function __top_mark__() {
    // @ts-ignore: Implicit this
    return f.apply(context || this, arguments);
            Severity: Minor
            Found in tools/utils/parse-stack.ts and 1 other location - About 55 mins to fix
            tools/utils/parse-stack.ts on lines 88..95

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status