Sign upLogin

meyfa/nsdlib

View on GitHub
Star

Showing 12 of 12 total issues

Method deserialize has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    private List<String> deserialize(String s)
    {
        if (!s.startsWith("\"") || !s.endsWith("\"")) {
            return Collections.singletonList(s);
        }
Severity: Minor
Found in src/main/java/nsdlib/reader/StructorizerReader.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method deserialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private List<String> deserialize(String s)
    {
        if (!s.startsWith("\"") || !s.endsWith("\"")) {
            return Collections.singletonList(s);
        }
Severity: Minor
Found in src/main/java/nsdlib/reader/StructorizerReader.java - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        private NSDTestLastLoop parseTestLastLoop(Element e) throws NSDReaderException
    {
        String label = deserialize(e.getAttribute("text")).get(0);
        NSDTestLastLoop loop = new NSDTestLastLoop(label);
    Severity: Major
    Found in src/main/java/nsdlib/reader/StructorizerReader.java and 2 other locations - About 50 mins to fix
    src/main/java/nsdlib/reader/StructorizerReader.java on lines 61..70
    src/main/java/nsdlib/reader/StructorizerReader.java on lines 229..238

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        private NSDRoot parseRoot(Element e) throws NSDReaderException
    {
        String label = deserialize(e.getAttribute("text")).get(0);
        NSDRoot root = new NSDRoot(label);
    Severity: Major
    Found in src/main/java/nsdlib/reader/StructorizerReader.java and 2 other locations - About 50 mins to fix
    src/main/java/nsdlib/reader/StructorizerReader.java on lines 229..238
    src/main/java/nsdlib/reader/StructorizerReader.java on lines 240..249

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        private NSDTestFirstLoop parseTestFirstLoop(Element e) throws NSDReaderException
    {
        String label = deserialize(e.getAttribute("text")).get(0);
        NSDTestFirstLoop loop = new NSDTestFirstLoop(label);
    Severity: Major
    Found in src/main/java/nsdlib/reader/StructorizerReader.java and 2 other locations - About 50 mins to fix
    src/main/java/nsdlib/reader/StructorizerReader.java on lines 61..70
    src/main/java/nsdlib/reader/StructorizerReader.java on lines 240..249

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if (hasTop) {
            Size boxSize = ctx.box(top);
            width = Math.max(width, boxSize.width);
            topHeight = boxSize.height;
            height += topHeight;
    Severity: Minor
    Found in src/main/java/nsdlib/rendering/parts/BraceRenderPart.java and 1 other location - About 40 mins to fix
    src/main/java/nsdlib/rendering/parts/BraceRenderPart.java on lines 76..81

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if (hasBottom) {
            Size boxSize = ctx.box(bottom);
            width = Math.max(width, boxSize.width);
            bottomHeight = boxSize.height;
            height += bottomHeight;
    Severity: Minor
    Found in src/main/java/nsdlib/rendering/parts/BraceRenderPart.java and 1 other location - About 40 mins to fix
    src/main/java/nsdlib/rendering/parts/BraceRenderPart.java on lines 69..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public RenderColor(int r, int g, int b, int a)
    {
        this.r = r;
        this.g = g;
        this.b = b;
    Severity: Minor
    Found in src/main/java/nsdlib/rendering/RenderColor.java and 1 other location - About 40 mins to fix
    src/main/java/nsdlib/rendering/renderer/RenderContext.java on lines 22..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public RenderContext(int padH, int padV, ToIntFunction<String> stringWidth, ToIntFunction<String> stringHeight)
    {
        this.padH = padH;
        this.padV = padV;
    Severity: Minor
    Found in src/main/java/nsdlib/rendering/renderer/RenderContext.java and 1 other location - About 40 mins to fix
    src/main/java/nsdlib/rendering/RenderColor.java on lines 38..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method fillRect has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public abstract void fillRect(int x, int y, int w, int h, RenderColor col);
    Severity: Minor
    Found in src/main/java/nsdlib/rendering/renderer/RenderAdapter.java - About 35 mins to fix

      Method fillRect has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public void fillRect(int x, int y, int w, int h, RenderColor col)
      Severity: Minor
      Found in src/main/java/nsdlib/rendering/renderer/awt/AwtRenderAdapter.java - About 35 mins to fix

        Method render has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            @Override
    public void render(RenderAdapter<?> adapter, int x, int y, int w)
    {
        if (children.isEmpty()) {
            return;
        Severity: Minor
        Found in src/main/java/nsdlib/rendering/parts/ContainerRenderPart.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language