Sign upLogin

meyfa/structogram2byob

View on GitHub
Star

Showing 21 of 21 total issues

Method isAssignableFrom has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean isAssignableFrom(BlockDescription o)
    {
        final int iMax = countParts(), jMax = o.countParts();
        int i, j;
Severity: Minor
Found in src/main/java/structogram2byob/blocks/BlockDescription.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package structogram2byob.blocks.special;

import java.util.List;

import scratchlib.objects.fixed.collections.ScratchObjectArray;
Severity: Major
Found in src/main/java/structogram2byob/blocks/special/ChangeVariableBlock.java and 1 other location - About 2 hrs to fix
src/main/java/structogram2byob/blocks/special/SetVariableBlock.java on lines 1..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package structogram2byob.blocks.special;

import java.util.List;

import scratchlib.objects.fixed.collections.ScratchObjectArray;
Severity: Major
Found in src/main/java/structogram2byob/blocks/special/SetVariableBlock.java and 1 other location - About 2 hrs to fix
src/main/java/structogram2byob/blocks/special/ChangeVariableBlock.java on lines 1..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package structogram2byob.blocks.structures;

import java.util.List;

import scratchlib.objects.fixed.collections.ScratchObjectArray;
Severity: Major
Found in src/main/java/structogram2byob/blocks/structures/IfBlock.java and 1 other location - About 1 hr to fix
src/main/java/structogram2byob/blocks/structures/RepeatBlock.java on lines 1..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package structogram2byob.blocks.structures;

import java.util.List;

import scratchlib.objects.fixed.collections.ScratchObjectArray;
Severity: Major
Found in src/main/java/structogram2byob/blocks/structures/RepeatBlock.java and 1 other location - About 1 hr to fix
src/main/java/structogram2byob/blocks/structures/IfBlock.java on lines 1..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public IDialog<File> createOpenDialog(FileFilter type)
    {
        JFileChooser chooser = new JFileChooser();
Severity: Minor
Found in src/main/java/structogram2byob/gui/dialogs/SwingDialogFactory.java and 1 other location - About 50 mins to fix
src/main/java/structogram2byob/gui/dialogs/SwingDialogFactory.java on lines 15..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public IDialog<File> createSaveDialog(FileFilter type)
    {
        JFileChooser chooser = new JFileChooser();
Severity: Minor
Found in src/main/java/structogram2byob/gui/dialogs/SwingDialogFactory.java and 1 other location - About 50 mins to fix
src/main/java/structogram2byob/gui/dialogs/SwingDialogFactory.java on lines 31..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method peekNumber has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    private Token peekNumber() throws LexerException
    {
        // collect all characters potentially part of the number
        StringBuilder sb = new StringBuilder();
        for (int i = index; i < input.length(); ++i) {
Severity: Minor
Found in src/main/java/structogram2byob/lexer/Lexer.java - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method doParse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    private BlockDescription doParse() throws LexerException, BlockDescriptionParserException
    {
        BlockDescription.Builder builder = new BlockDescription.Builder();

        while (lexer.hasNext()) {
Severity: Minor
Found in src/main/java/structogram2byob/parser/blockdescription/BlockDescriptionParser.java - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

package structogram2byob.parser;

/**
 * Exception thrown when there is a problem while constructing an AST from a
 * given input.
Severity: Major
Found in src/main/java/structogram2byob/parser/AstParserException.java and 4 other locations - About 40 mins to fix
src/main/java/structogram2byob/blocks/BlockRegistryReaderException.java on lines 1..48
src/main/java/structogram2byob/lexer/LexerException.java on lines 1..48
src/main/java/structogram2byob/parser/blockdescription/BlockDescriptionParserException.java on lines 1..48
src/main/java/structogram2byob/parser/expression/ExpressionParserException.java on lines 1..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

package structogram2byob.parser.expression;

/**
 * Exception thrown when there is a problem while parsing an expression.
 */
Severity: Major
Found in src/main/java/structogram2byob/parser/expression/ExpressionParserException.java and 4 other locations - About 40 mins to fix
src/main/java/structogram2byob/blocks/BlockRegistryReaderException.java on lines 1..48
src/main/java/structogram2byob/lexer/LexerException.java on lines 1..48
src/main/java/structogram2byob/parser/AstParserException.java on lines 1..49
src/main/java/structogram2byob/parser/blockdescription/BlockDescriptionParserException.java on lines 1..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

package structogram2byob.parser.blockdescription;

/**
 * Exception thrown when there is a problem while parsing a block description.
 */
Severity: Major
Found in src/main/java/structogram2byob/parser/blockdescription/BlockDescriptionParserException.java and 4 other locations - About 40 mins to fix
src/main/java/structogram2byob/blocks/BlockRegistryReaderException.java on lines 1..48
src/main/java/structogram2byob/lexer/LexerException.java on lines 1..48
src/main/java/structogram2byob/parser/AstParserException.java on lines 1..49
src/main/java/structogram2byob/parser/expression/ExpressionParserException.java on lines 1..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

package structogram2byob.lexer;

/**
 * Exception thrown when there is a problem during the lexical analysis phase.
 */
Severity: Major
Found in src/main/java/structogram2byob/lexer/LexerException.java and 4 other locations - About 40 mins to fix
src/main/java/structogram2byob/blocks/BlockRegistryReaderException.java on lines 1..48
src/main/java/structogram2byob/parser/AstParserException.java on lines 1..49
src/main/java/structogram2byob/parser/blockdescription/BlockDescriptionParserException.java on lines 1..48
src/main/java/structogram2byob/parser/expression/ExpressionParserException.java on lines 1..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

package structogram2byob.blocks;

/**
 * Exception thrown when there is a problem while reading a block registry.
 */
Severity: Major
Found in src/main/java/structogram2byob/blocks/BlockRegistryReaderException.java and 4 other locations - About 40 mins to fix
src/main/java/structogram2byob/lexer/LexerException.java on lines 1..48
src/main/java/structogram2byob/parser/AstParserException.java on lines 1..49
src/main/java/structogram2byob/parser/blockdescription/BlockDescriptionParserException.java on lines 1..48
src/main/java/structogram2byob/parser/expression/ExpressionParserException.java on lines 1..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method toScratch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public ScratchObjectAbstractCollection toScratch(VariableMap vars, BlockRegistry blocks)
            throws ScratchConversionException
    {
        ScratchObjectArray arr = new ScratchObjectArray();
Severity: Minor
Found in src/main/java/structogram2byob/program/ProgramUnit.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return peekLabel();
Severity: Major
Found in src/main/java/structogram2byob/lexer/Lexer.java - About 30 mins to fix

    Method lookup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public Block lookup(BlockDescription desc)
    {
        Block baseLookup = base != null ? base.lookup(desc) : null;
        if (baseLookup != null) {
            return baseLookup;
    Severity: Minor
    Found in src/main/java/structogram2byob/blocks/BlockRegistry.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method registerUnits has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private void registerUnits(BlockRegistry registry) throws ScratchConversionException
    {
        for (ProgramUnit u : units) {
            if (u.getType() != UnitType.SCRIPT) {
                try {
    Severity: Minor
    Found in src/main/java/structogram2byob/program/Program.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method toScratch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public ScratchObject toScratch(VariableMap vars, BlockRegistry blocks) throws ScratchConversionException
    {
        // check if this is a variable
        if (description.countParts() == 1 && !description.isParameter(0)) {
    Severity: Minor
    Found in src/main/java/structogram2byob/program/expressions/BlockExpression.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method peekToken has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private Token peekToken() throws LexerException
    {
        char c = input.charAt(index);

        if (c == '(') {
    Severity: Minor
    Found in src/main/java/structogram2byob/lexer/Lexer.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language