Sign upLogin

mezuro/kalibro_client_py

View on GitHub
Star
kalibro_client/processor/module_result.py

Summary

Maintainability
C
1 day
Test Coverage

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, grade, processing_id, parent_id=None, *args,
Severity: Minor
Found in kalibro_client/processor/module_result.py - About 35 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        def _asdict(self):
        dict_ = super(ModuleResult, self)._asdict()
        dict_['grade'] = self.grade
        dict_['parent_id'] = self.parent_id
        dict_['processing_id'] = self.processing_id
    Severity: Major
    Found in kalibro_client/processor/module_result.py and 2 other locations - About 3 hrs to fix
    kalibro_client/processor/processing.py on lines 57..62
    kalibro_client/processor/repository.py on lines 58..65

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @property
    def processing(self):
        if self._processing is None:
            self._processing = Processing.find(self.processing_id)
    Severity: Major
    Found in kalibro_client/processor/module_result.py and 1 other location - About 1 hr to fix
    kalibro_client/configurations/kalibro_range.py on lines 31..36

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

        @parent_id.setter
    def parent_id(self, value):
        if value is not None:
            value = int(value)
    Severity: Major
    Found in kalibro_client/processor/module_result.py and 16 other locations - About 55 mins to fix
    kalibro_client/base.py on lines 179..184
    kalibro_client/configurations/metric_configuration.py on lines 21..26
    kalibro_client/configurations/metric_configuration.py on lines 32..37
    kalibro_client/configurations/metric_configuration.py on lines 43..47
    kalibro_client/configurations/reading.py on lines 14..19
    kalibro_client/processor/hotspot_metric_result.py on lines 17..22
    kalibro_client/processor/metric_result.py on lines 24..29
    kalibro_client/processor/metric_result.py on lines 35..40
    kalibro_client/processor/module_result.py on lines 25..30
    kalibro_client/processor/process_time.py on lines 19..24
    kalibro_client/processor/processing.py on lines 28..33
    kalibro_client/processor/processing.py on lines 50..55
    kalibro_client/processor/repository.py on lines 29..34
    kalibro_client/processor/repository.py on lines 40..45
    kalibro_client/processor/repository.py on lines 51..56
    kalibro_client/processor/tree_metric_result.py on lines 16..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

        @grade.setter
    def grade(self, value):
        if value is not None:
            value = float(value)
    Severity: Major
    Found in kalibro_client/processor/module_result.py and 16 other locations - About 55 mins to fix
    kalibro_client/base.py on lines 179..184
    kalibro_client/configurations/metric_configuration.py on lines 21..26
    kalibro_client/configurations/metric_configuration.py on lines 32..37
    kalibro_client/configurations/metric_configuration.py on lines 43..47
    kalibro_client/configurations/reading.py on lines 14..19
    kalibro_client/processor/hotspot_metric_result.py on lines 17..22
    kalibro_client/processor/metric_result.py on lines 24..29
    kalibro_client/processor/metric_result.py on lines 35..40
    kalibro_client/processor/module_result.py on lines 36..41
    kalibro_client/processor/process_time.py on lines 19..24
    kalibro_client/processor/processing.py on lines 28..33
    kalibro_client/processor/processing.py on lines 50..55
    kalibro_client/processor/repository.py on lines 29..34
    kalibro_client/processor/repository.py on lines 40..45
    kalibro_client/processor/repository.py on lines 51..56
    kalibro_client/processor/tree_metric_result.py on lines 16..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def tree_metric_results(self):
        return TreeMetricResult.response_to_objects_array(self.request(
                                                action=':id/metric_results',
                                                params={'id': self.id},
    Severity: Major
    Found in kalibro_client/processor/module_result.py and 3 other locations - About 45 mins to fix
    kalibro_client/processor/module_result.py on lines 58..61
    kalibro_client/processor/module_result.py on lines 108..110
    kalibro_client/processor/module_result.py on lines 112..114

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def hotspot_metric_results(self):
        return HotspotMetricResult.response_to_objects_array(self.request(action=':id/hotspot_metric_results',
                                                                          params={'id': self.id}, method='get'))
    Severity: Major
    Found in kalibro_client/processor/module_result.py and 3 other locations - About 45 mins to fix
    kalibro_client/processor/module_result.py on lines 58..61
    kalibro_client/processor/module_result.py on lines 102..105
    kalibro_client/processor/module_result.py on lines 112..114

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def descendant_hotspot_metric_results(self):
        return HotspotMetricResult.response_to_objects_array(
            self.request(action=':id/descendant_hotspot_metric_results', params={'id': self.id}, method='get'))
    Severity: Major
    Found in kalibro_client/processor/module_result.py and 3 other locations - About 45 mins to fix
    kalibro_client/processor/module_result.py on lines 58..61
    kalibro_client/processor/module_result.py on lines 102..105
    kalibro_client/processor/module_result.py on lines 108..110

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def children(self):
        return self.response_to_objects_array(self.request(
                                                action=':id/children',
                                                params={'id': self.id},
    Severity: Major
    Found in kalibro_client/processor/module_result.py and 3 other locations - About 45 mins to fix
    kalibro_client/processor/module_result.py on lines 102..105
    kalibro_client/processor/module_result.py on lines 108..110
    kalibro_client/processor/module_result.py on lines 112..114

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status