mgrachev/dom_for

View on GitHub

Showing 4 of 4 total issues

Method _dom_for_model has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def _dom_for_model(klass, tag, user_class, attrs = {}, &block)
      object_classes  = []
      class_name      = klass.to_s.underscore
      request_action  = request.path_parameters[:action]

Severity: Minor
Found in lib/dom_for/model.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _dom_for_record has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _dom_for_record(record, tag, user_class, attrs = {}, &block)
Severity: Minor
Found in lib/dom_for/record.rb - About 35 mins to fix

    Method _dom_for_model has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _dom_for_model(klass, tag, user_class, attrs = {}, &block)
    Severity: Minor
    Found in lib/dom_for/model.rb - About 35 mins to fix

      Method _dom_for_record has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def _dom_for_record(record, tag, user_class, attrs = {}, &block)
            object_id     = dom_id(record)
            object_class  = dom_class(record.class)
            html_class    = [object_class, user_class].compact
      
      
      Severity: Minor
      Found in lib/dom_for/record.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language