Sign upLogin

mgurbanzade/gendiff

View on GitHub
Star

Showing 7 of 7 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        'with extensions of %s', (i) => {
          const firstFilePath = findFixture(`${firstFileName}${i}`);
          const secondFilePath = findFixture(`${secondFileName}${i}`);
          const actual = gendiff(firstFilePath, secondFilePath, format);
          const expected = fs.readFileSync(findFixture(`${expectedFileName}`), 'utf-8');
Severity: Major
Found in __tests__/index.test.js and 1 other location - About 3 hrs to fix
__tests__/index.test.js on lines 29..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        (ex1, ex2) => {
          const firstFilePath = findFixture(`${firstFileName}${ex1}`);
          const secondFilePath = findFixture(`${secondFileName}${ex2}`);
          const actual = gendiff(firstFilePath, secondFilePath, format);
          const expected = fs.readFileSync(findFixture(`${expectedFileName}`), 'utf-8');
Severity: Major
Found in __tests__/index.test.js and 1 other location - About 3 hrs to fix
__tests__/index.test.js on lines 11..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function runTests has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  const runTests = (firstFileName, secondFileName, expectedFileName, format = 'graphical') => {
    describe(`with ${format} output format`, () => {
      test.each(['.json', '.yml', '.ini'])(
        'with extensions of %s', (i) => {
          const firstFilePath = findFixture(`${firstFileName}${i}`);
Severity: Minor
Found in __tests__/index.test.js - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      added: (node, depth) => `${indent(depth + 2)}+ ${node.keyName}: ${stringifyObj(node.newValue, depth)}`,
    Severity: Minor
    Found in src/renderers/graphicalRenderer.js and 2 other locations - About 40 mins to fix
    src/renderers/graphicalRenderer.js on lines 13..13
    src/renderers/graphicalRenderer.js on lines 15..15

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      unchanged: (node, depth) => `${indent(depth + 4)}${node.keyName}: ${stringifyObj(node.newValue, depth)}`,
    Severity: Minor
    Found in src/renderers/graphicalRenderer.js and 2 other locations - About 40 mins to fix
    src/renderers/graphicalRenderer.js on lines 14..14
    src/renderers/graphicalRenderer.js on lines 15..15

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      removed: (node, depth) => `${indent(depth + 2)}- ${node.keyName}: ${stringifyObj(node.oldValue, depth)}`,
    Severity: Minor
    Found in src/renderers/graphicalRenderer.js and 2 other locations - About 40 mins to fix
    src/renderers/graphicalRenderer.js on lines 13..13
    src/renderers/graphicalRenderer.js on lines 14..14

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

        return [...acc, buildNode('removed', key, dataObjVal1, null)];
    Severity: Major
    Found in src/astBuilder.js - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language