Sign upLogin

mheinzerling/php-databaseutils

View on GitHub
Star
src/DatabaseUtils.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function importDump has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public static function importDump(\PDO $pdo, string $sqlFile): bool
    {
        $content = file_get_contents($sqlFile);
        $queries = explode(";\n", str_replace("\r", "", $content));
        $pdo->beginTransaction();
Severity: Minor
Found in src/DatabaseUtils.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method onDuplicateAndExec has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private static function onDuplicateAndExec(\PDO $pdo, int $onDuplicate, array $keys, string $sql, array $params): int
Severity: Minor
Found in src/DatabaseUtils.php - About 35 mins to fix

    Method insertMultiple has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static function insertMultiple(\PDO $pdo, string $table, array $keys, array $datas, int $onDuplicate = self::DUPLICATE_FAIL): int
    Severity: Minor
    Found in src/DatabaseUtils.php - About 35 mins to fix

      Avoid unused local variables such as '$key'.
      Open

              foreach ($data as $key => &$value) {
      Severity: Minor
      Found in src/DatabaseUtils.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused parameters such as '$_'.
      Open

                  $updateAssignment = StringUtils::implode(", ", $keys, function ($_, $key) {
      Severity: Minor
      Found in src/DatabaseUtils.php by phpmd

      UnusedFormalParameter

      Since: 0.2

      Avoid passing parameters to methods or constructors and then not using those parameters.

      Example

      class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

      There are no issues that match your filters.

      Category
      Status