src/TestDatabaseConnection.php
The method __construct has a boolean flag argument $dropDatabaseAtShutdown, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function __construct(bool $dropDatabaseAtShutdown = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid unused private methods such as 'envWithFallback'. Open
Open
private static function envWithFallback(string $key, string $default = null): string
{
$value = getenv($key);
if ($value === false) return $default;
return $value;- Read upRead up
- Exclude checks
UnusedPrivateMethod
Since: 0.2
Unused Private Method detects when a private method is declared but is unused.
Example
class Something
{
private function foo() {} // unused
}