mheinzerling/php-databaseutils

View on GitHub
src/structure/Table.php

Summary

Maintainability
C
1 day
Test Coverage

Function migrate has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    public function migrate(Migration $migration, Table $before, SqlSetting $setting): void
    {
        //TODO rename
        $meta = [];
        if ($this->engine != $before->engine) $meta[] = "ENGINE=" . $this->engine;
Severity: Minor
Found in src/structure/Table.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class Table has an overall complexity of 76 which is very high. The configured complexity threshold is 50.
Open

class Table
{
    /**
     * @var Database
     */
Severity: Minor
Found in src/structure/Table.php by phpmd

Method migrate has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function migrate(Migration $migration, Table $before, SqlSetting $setting): void
    {
        //TODO rename
        $meta = [];
        if ($this->engine != $before->engine) $meta[] = "ENGINE=" . $this->engine;
Severity: Minor
Found in src/structure/Table.php - About 1 hr to fix

    Function resolveLazyIndexes has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function resolveLazyIndexes(): void
        {
            foreach ($this->indexes as &$index) {
                if (StringUtils::contains(get_class($index), "lazy")) {
                    if ($index instanceof LazyIndex || $index instanceof LazyUnique) {
    Severity: Minor
    Found in src/structure/Table.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function toCreateSql has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function toCreateSql(SqlSetting $setting): string
        {
            $delimiter = $setting->singleLine ? " " : "\n";
            $sql = 'CREATE TABLE ';
            if ($setting->createTableIfNotExists) $sql .= 'IF NOT EXISTS ';
    Severity: Minor
    Found in src/structure/Table.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function toBuilderCode has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function toBuilderCode(): string
        {
            $result = "\n    ->table(\"" . $this->name . "\")";
            foreach ($this->indexes as $index) {
                $result .= $index->toBuilderCode();
    Severity: Minor
    Found in src/structure/Table.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function hasForeignKeysOnlyOn has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function hasForeignKeysOnlyOn(array $tables): bool
        {
            if (empty($this->indexes)) return true;
            $names = array_keys($tables);
            foreach ($this->indexes as $index) {
    Severity: Minor
    Found in src/structure/Table.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method toCreateSql() has an NPath complexity of 5376. The configured NPath complexity threshold is 200.
    Open

        public function toCreateSql(SqlSetting $setting): string
        {
            $delimiter = $setting->singleLine ? " " : "\n";
            $sql = 'CREATE TABLE ';
            if ($setting->createTableIfNotExists) $sql .= 'IF NOT EXISTS ';
    Severity: Minor
    Found in src/structure/Table.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
        function bar() {
            // lots of complicated code
        }
    }

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method migrate() has an NPath complexity of 48384. The configured NPath complexity threshold is 200.
    Open

        public function migrate(Migration $migration, Table $before, SqlSetting $setting): void
        {
            //TODO rename
            $meta = [];
            if ($this->engine != $before->engine) $meta[] = "ENGINE=" . $this->engine;
    Severity: Minor
    Found in src/structure/Table.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
        function bar() {
            // lots of complicated code
        }
    }

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method toBuilderCode() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public function toBuilderCode(): string
        {
            $result = "\n    ->table(\"" . $this->name . "\")";
            foreach ($this->indexes as $index) {
                $result .= $index->toBuilderCode();
    Severity: Minor
    Found in src/structure/Table.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    The method migrate() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10.
    Open

        public function migrate(Migration $migration, Table $before, SqlSetting $setting): void
        {
            //TODO rename
            $meta = [];
            if ($this->engine != $before->engine) $meta[] = "ENGINE=" . $this->engine;
    Severity: Minor
    Found in src/structure/Table.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    The method toCreateSql() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
    Open

        public function toCreateSql(SqlSetting $setting): string
        {
            $delimiter = $setting->singleLine ? " " : "\n";
            $sql = 'CREATE TABLE ';
            if ($setting->createTableIfNotExists) $sql .= 'IF NOT EXISTS ';
    Severity: Minor
    Found in src/structure/Table.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    The class Table has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
    Open

    class Table
    {
        /**
         * @var Database
         */
    Severity: Minor
    Found in src/structure/Table.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
        /**
         * @var \foo\bar\X
         */
        private $x = null;
    
        /**
         * @var \foo\bar\Y
         */
        private $y = null;
    
        /**
         * @var \foo\bar\Z
         */
        private $z = null;
    
        public function setFoo(\Foo $foo) {}
        public function setBar(\Bar $bar) {}
        public function setBaz(\Baz $baz) {}
    
        /**
         * @return \SplObjectStorage
         * @throws \OutOfRangeException
         * @throws \InvalidArgumentException
         * @throws \ErrorException
         */
        public function process(\Iterator $it) {}
    
        // ...
    }

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Missing class import via use statement (line '158', column '51').
    Open

            else if (count($primaries) > 1) throw new \Exception("Unsupported");
    Severity: Minor
    Found in src/structure/Table.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '88', column '31').
    Open

                        throw new \Exception("Found lazy index/unique that should have been resolved already");
    Severity: Minor
    Found in src/structure/Table.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '168', column '47').
    Open

            else if (count($autos) > 1) throw new \Exception("Unsupported");
    Severity: Minor
    Found in src/structure/Table.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '92', column '31').
    Open

                        throw new \Exception("Found unknown lazy index that should have been resolved already or need to be added here");
    Severity: Minor
    Found in src/structure/Table.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    TODO found
    Open

            //TODO rename
    Severity: Minor
    Found in src/structure/Table.php by fixme

    Avoid variables with short names like $p. Configured minimum length is 3.
    Open

            $primaries = array_filter($this->indexes, function (Index $p) {
    Severity: Minor
    Found in src/structure/Table.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $f. Configured minimum length is 3.
    Open

            $autos = array_filter($this->fields, function (Field $f) {
    Severity: Minor
    Found in src/structure/Table.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $i. Configured minimum length is 3.
    Open

            return array_filter($this->indexes, function (Index $i) {
    Severity: Minor
    Found in src/structure/Table.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status