Sign upLogin

mheinzerling/php-databaseutils

View on GitHub
Star
src/structure/type/Type.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function fromSql has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public static function fromSql(string $type, string $collation = null, bool $isBoolean = false): Type
    {
        //TODO register parser
        $result = BoolType::parseBool($type);
        if ($result != null) return $result;
Severity: Minor
Found in src/structure/type/Type.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        if ($result != null) return $result;
Severity: Major
Found in src/structure/type/Type.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            if ($result != null) return $result;
    Severity: Major
    Found in src/structure/type/Type.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              if ($result != null) return $result;
      Severity: Major
      Found in src/structure/type/Type.php - About 30 mins to fix

        The method fromSql() has an NPath complexity of 256. The configured NPath complexity threshold is 200.
        Open

            public static function fromSql(string $type, string $collation = null, bool $isBoolean = false): Type
    {
        //TODO register parser
        $result = BoolType::parseBool($type);
        if ($result != null) return $result;
        Severity: Minor
        Found in src/structure/type/Type.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
    function bar() {
        // lots of complicated code
    }
}

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        Missing class import via use statement (line '73', column '19').
        Open

                throw new \Exception("Unknown sql type: " . $type);
        Severity: Minor
        Found in src/structure/type/Type.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        The method fromSql has a boolean flag argument $isBoolean, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public static function fromSql(string $type, string $collation = null, bool $isBoolean = false): Type
        Severity: Minor
        Found in src/structure/type/Type.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
    public function bar($flag = true) {
    }
}

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        TODO found
        Open

                //TODO register parser
        Severity: Minor
        Found in src/structure/type/Type.php by fixme

        There are no issues that match your filters.

        Category
        Status