Sign upLogin

mhenrixon/sidekiq-unique-jobs

View on GitHub
Star
lib/sidekiq_unique_jobs/orphans/ruby_reaper.rb

Summary

Maintainability
C
7 hrs
Test Coverage
A
96%

Method active? has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

      def active?(digest) # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
        Sidekiq.redis do |conn|
          procs = conn.sscan("processes").to_a
          return false if procs.empty?
Severity: Minor
Found in lib/sidekiq_unique_jobs/orphans/ruby_reaper.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method orphans has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

      def orphans # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
        orphans = []
        page    = 0
        per     = reaper_count * 2
        results = digests.byscore(0, max_score, offset: page * per, count: (page + 1) * per)
Severity: Minor
Found in lib/sidekiq_unique_jobs/orphans/ruby_reaper.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Complex method SidekiqUniqueJobs::Orphans::RubyReaper#orphans (39.6)
Open

      def orphans # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
        orphans = []
        page    = 0
        per     = reaper_count * 2
        results = digests.byscore(0, max_score, offset: page * per, count: (page + 1) * per)
Severity: Minor
Found in lib/sidekiq_unique_jobs/orphans/ruby_reaper.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Complex method SidekiqUniqueJobs::Orphans::RubyReaper#active? (34.8)
Open

      def active?(digest) # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
        Sidekiq.redis do |conn|
          procs = conn.sscan("processes").to_a
          return false if procs.empty?
Severity: Minor
Found in lib/sidekiq_unique_jobs/orphans/ruby_reaper.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Complex method SidekiqUniqueJobs::Orphans::RubyReaper#entries (22.2)
Open

      def entries(conn, queue, &block) # rubocop:disable Metrics/MethodLength
        queue_key    = "queue:#{queue}"
        initial_size = conn.llen(queue_key)
        deleted_size = 0
        page         = 0
Severity: Minor
Found in lib/sidekiq_unique_jobs/orphans/ruby_reaper.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

TODO found
Open

              # TODO: Remove the if statement in the future
Severity: Minor
Found in lib/sidekiq_unique_jobs/orphans/ruby_reaper.rb by fixme

There are no issues that match your filters.

Category
Status