Sign upLogin

michaeldouglas/laravel-pagseguro

View on GitHub
Star
tests/unit/Payment/Method/FactoryTest.php

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function testCreditCard()
    {
        $method = MethodFactory::factory(
            MethodInterface::TYPE_CREDIT_CARD,
            CreditCardInterface::VISA
Severity: Major
Found in tests/unit/Payment/Method/FactoryTest.php and 3 other locations - About 2 hrs to fix
tests/unit/Payment/Method/FactoryTest.php on lines 60..73
tests/unit/Payment/Method/FactoryTest.php on lines 78..91
tests/unit/Payment/Method/FactoryTest.php on lines 132..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function testTransfer()
    {
        $method = MethodFactory::factory(
            MethodInterface::TYPE_TRANSFER,
            TransferInterface::HSBC
Severity: Major
Found in tests/unit/Payment/Method/FactoryTest.php and 3 other locations - About 2 hrs to fix
tests/unit/Payment/Method/FactoryTest.php on lines 42..55
tests/unit/Payment/Method/FactoryTest.php on lines 60..73
tests/unit/Payment/Method/FactoryTest.php on lines 132..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function testBillet()
    {
        $method = MethodFactory::factory(
            MethodInterface::TYPE_BILLET,
            BilletInterface::BRADESCO
Severity: Major
Found in tests/unit/Payment/Method/FactoryTest.php and 3 other locations - About 2 hrs to fix
tests/unit/Payment/Method/FactoryTest.php on lines 42..55
tests/unit/Payment/Method/FactoryTest.php on lines 78..91
tests/unit/Payment/Method/FactoryTest.php on lines 132..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function testDepositAccount()
    {
        $method = MethodFactory::factory(
            MethodInterface::TYPE_DEPOSIT_ACCOUNT,
            DepositAccountInterface::BANCO_DO_BRASIL
Severity: Major
Found in tests/unit/Payment/Method/FactoryTest.php and 3 other locations - About 2 hrs to fix
tests/unit/Payment/Method/FactoryTest.php on lines 42..55
tests/unit/Payment/Method/FactoryTest.php on lines 60..73
tests/unit/Payment/Method/FactoryTest.php on lines 78..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testPsCredit()
    {
        $method = MethodFactory::factory(
            MethodInterface::TYPE_PS_CREDIT,
            ExtrasInterface::PS_CREDIT
Severity: Major
Found in tests/unit/Payment/Method/FactoryTest.php and 1 other location - About 2 hrs to fix
tests/unit/Payment/Method/FactoryTest.php on lines 114..127

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 124.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testOiPaggo()
    {
        $method = MethodFactory::factory(
            MethodInterface::TYPE_OI_PAGGO,
            ExtrasInterface::OI_PAGGO
Severity: Major
Found in tests/unit/Payment/Method/FactoryTest.php and 1 other location - About 2 hrs to fix
tests/unit/Payment/Method/FactoryTest.php on lines 96..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 124.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status