Sign upLogin

michalc/aiofastforward

View on GitHub
Star

Showing 4 of 4 total issues

File test.py has 484 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import asyncio
import unittest
from threading import (
    Thread,
)
Severity: Minor
Found in test.py - About 7 hrs to fix

    Function _run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def _run(self):
        # Resolve all forwards strictly before first callback if there is one
        while \
                self._callbacks_queue.queue and self._forwards_queue.queue \
                and self._forwards_queue.queue[0] <  self._callbacks_queue.queue[0]:
    Severity: Minor
    Found in aiofastforward.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create_callback has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def create_callback(when, callback, args, loop, _):
    Severity: Minor
    Found in aiofastforward.py - About 35 mins to fix

      Function create_callback has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def create_callback(when, callback, args, loop, context):
      Severity: Minor
      Found in aiofastforward.py - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language