michielbdejong/solid-panes

View on GitHub

Showing 327 of 327 total issues

Function onDragEnter has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  onDragEnter: function (e, _dragSession) {
    // enter or exit something
    try {
      var selection = UI.utils.ancestor(
        UI.utils.ancestor(e.originalTarget, 'TABLE').parentNode,
Severity: Minor
Found in src/outline/dragDrop.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function renderPane has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

                var renderPane = function (pane) {
                  var paneDiv
                  UI.log.info('outline: Rendering pane (2): ' + pane.name)
                  if (UI.no_catch_pane_errors) {
                    // for debugging
Severity: Minor
Found in src/outline/manager.js - About 1 hr to fix

    Function TabulatorMousedown has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function TabulatorMousedown (e) {
        UI.log.info('@TabulatorMousedown, dom.location is now ' + dom.location)
        var target = thisOutline.targetOf(e)
        if (!target) return
        var tname = target.tagName
    Severity: Minor
    Found in src/outline/manager.js - About 1 hr to fix

      Function isVideo has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function isVideo (src, _index) {
            if (!src) {
              return {
                html5: true
              }
      Severity: Minor
      Found in src/playlist/playlistPane.js - About 1 hr to fix

        Function cellFunction has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                options.cellFunction = function (cell, x, y, value) {
                  if (value !== null) {
                    kb.fetcher.nowOrWhenFetched(
                      value.uri.split('#')[0],
                      undefined,
        Severity: Minor
        Found in src/schedule/schedulePane.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                    for (var triple in d) {
                      kb.add(
                        d[triple].subject,
                        d[triple].predicate,
                        d[triple].object,
          Severity: Major
          Found in src/microblogPane/microblogPane.js and 1 other location - About 1 hr to fix
          src/microblogPane/microblogPane.js on lines 708..715

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                        for (var triple in d) {
                          kb.add(
                            d[triple].subject,
                            d[triple].predicate,
                            d[triple].object,
          Severity: Major
          Found in src/microblogPane/microblogPane.js and 1 other location - About 1 hr to fix
          src/microblogPane/microblogPane.js on lines 334..341

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function streamView has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              Pane.prototype.streamView = function (s, doc) {
                var postContainer = doc.createElement('div')
                postContainer.id = 'postContainer'
                postContainer.className = 'post-container view-container active'
                var mbPosts = []
          Severity: Minor
          Found in src/microblogPane/microblogPane.js - About 1 hr to fix

            Function calculations has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  var calculations = function () {
                    var total = {}
                    var trans = kb.each(undefined, TRIP('trip'), subject)
                    // complain("@@ Number of transactions in this trip: " + trans.length);
                    trans.map(function (t) {
            Severity: Minor
            Found in src/trip/tripPane.js - About 1 hr to fix

              Function setAttachment has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  var setAttachment = function (x, y, value, refresh) {
                    if (kb.holds(x, predicate, y) === value) return
                    var verb = value ? 'attach' : 'detach'
                    // complain("Info: starting to "+verb+" " + y.uri + " to "+x.uri+ ":\n")
                    var linkDone3 = function (uri, ok, body) {
              Severity: Minor
              Found in src/attach/attachPane.js - About 1 hr to fix

                Function showBootstrap has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    var showBootstrap = function showBootstrap () {
                      var div = clearElement(naviMain)
                      div.appendChild(
                        UI.authn.newAppInstance(
                          dom,
                Severity: Minor
                Found in src/schedule/schedulePane.js - About 1 hr to fix

                  Function label has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    label: function (subject, context) {
                      var kb = context.session.store
                      if (
                        !kb.anyStatementMatching(
                          subject,
                  Severity: Minor
                  Found in src/imagePane.js - About 1 hr to fix

                    Function outlineCollapse has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      function outlineCollapse (p, subject) {
                        var row = UI.utils.ancestor(p, 'TR')
                        row = UI.utils.ancestor(row.parentNode, 'TR') // two levels up
                        if (row) var statement = row.AJAR_statement
                        var level // find level (the enclosing TD)
                    Severity: Minor
                    Found in src/outline/manager.js - About 1 hr to fix

                      Function render has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        render: function (subject, context) {
                          var dom = context.dom
                          var styleSheet =
                            'https://leemark.github.io/better-simple-slideshow/css/simple-slideshow-styles.css'
                          UI.widgets.addStyleSheet(dom, styleSheet)
                      Severity: Minor
                      Found in src/slideshow/slideshowPane.js - About 1 hr to fix

                        Function getMembersAndSort has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            var getMembersAndSort = function (subject) {
                              var sortBy = getSortKey(subject)
                              var u, x, key
                              var uriHash = kb.findMemberURIs(subject)
                              var pairs = []
                        Severity: Minor
                        Found in src/attach/attachPane.js - About 1 hr to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      if (UI.utils.getTarget(e).className === 'bottom-border') {
                                        border.style.borderColor = 'rgb(100%,65%,0%)'
                                        border.style.cursor = 'copy'
                                      }
                          Severity: Major
                          Found in src/outline/userInput.js and 1 other location - About 1 hr to fix
                          src/outline/userInput.js on lines 1440..1443

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 57.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (UI.utils.getTarget(e).className === 'bottom-border') {
                                    border.style.borderColor = 'transparent'
                                    border.style.cursor = 'auto'
                                  }
                          Severity: Major
                          Found in src/outline/userInput.js and 1 other location - About 1 hr to fix
                          src/outline/userInput.js on lines 1426..1429

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 57.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Function render has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                          Open

                            render: function (subject, context) {
                              var dom = context.dom
                          
                              var filter = function (pred, inverse) {
                                if (
                          Severity: Minor
                          Found in src/defaultPane.js - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function render has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                          Open

                            render: function (subject, context) {
                              const store = context.session.store
                          
                              async function doRender (
                                container: HTMLElement,
                          Severity: Minor
                          Found in src/profile/profile.view.ts - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function addNewObject has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              addNewObject: function addNewObject (e) {
                                var predicateTd = UI.utils.getTarget(e).parentNode.parentNode
                                // var predicateTerm = UI.utils.getAbout(kb, predicateTd)
                                var isInverse = predicateTd.parentNode.AJAR_inverse
                                // var titleTerm=UI.utils.getAbout(kb,UI.utils.ancestor(predicateTd.parentNode,'TD'));
                          Severity: Minor
                          Found in src/outline/userInput.js - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language