Sign upLogin

michielbdejong/solid-panes

View on GitHub
Star

Showing 327 of 327 total issues

Function createApplicationEntry has 121 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createApplicationEntry (
  subject: NamedNode,
  origin: NamedNode | null,
  appModes: NamedNode[],
  updateTable: () => void
Severity: Major
Found in src/trustedApplications/trustedApplications.dom.ts - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        var hasContentTypeIn = function (kb, x, displayables) {
      var cts = kb.fetcher.getHeader(x, 'content-type')
      if (cts) {
        for (var j = 0; j < cts.length; j++) {
          for (var k = 0; k < displayables.length; k++) {
    Severity: Major
    Found in src/humanReadablePane.js and 1 other location - About 4 hrs to fix
    src/dokieli/dokieliPane.js on lines 34..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 131.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        var hasContentTypeIn = function (kb, x, displayables) {
      var cts = kb.fetcher.getHeader(x, 'content-type')
      if (cts) {
        for (var j = 0; j < cts.length; j++) {
          for (var k = 0; k < displayables.length; k++) {
    Severity: Major
    Found in src/dokieli/dokieliPane.js and 1 other location - About 4 hrs to fix
    src/humanReadablePane.js on lines 30..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 131.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function renderPaneIconTray has 115 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async function renderPaneIconTray (td, options = {}) {
      const paneShownStyle =
        'width: 24px; border-radius: 0.5em; border-top: solid #222 1px; border-left: solid #222 0.1em; border-bottom: solid #eee 0.1em; border-right: solid #eee 0.1em; margin-left: 1em; padding: 3px; background-color:   #ffd;'
      const paneHiddenStyle =
        'width: 24px; border-radius: 0.5em; margin-left: 1em; padding: 3px'
    Severity: Major
    Found in src/outline/manager.js - About 4 hrs to fix

      Function Refill has 111 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          Refill: function Refill (e, selectedTd) {
      UI.log.info('Refill' + selectedTd.textContent)
      var isPredicate = selectedTd.nextSibling
      var predicateQuery
      if (isPredicate) {
      Severity: Major
      Found in src/outline/userInput.js - About 4 hrs to fix

        Function initializeNewInstanceAtBase has 111 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            var initializeNewInstanceAtBase = function (
      thisInstance: any,
      newBase: string
    ) {
      var here = sym(thisInstance.uri.split('#')[0])
        Severity: Major
        Found in src/pad/padPane.ts - About 4 hrs to fix

          Function QuerySource has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
          Open

          function QuerySource () {
  /**
   * stores all of the queries currently held by this source,
   * indexed by ID number.
   */
          Severity: Minor
          Found in src/outline/queryByExample.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function render has 107 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            render: function (subject, context) {
    const myDocument = context.dom
    function isVideo (src, _index) {
      if (!src) {
        return {
          Severity: Major
          Found in src/playlist/playlistPane.js - About 4 hrs to fix

            Function calculations has 107 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  var calculations = function () {
        var total = {}
        var yearTotal = {}
        var yearCategoryTotal = {}
        var trans = kb.each(undefined, TRIP('trip'), subject)
            Severity: Major
            Found in src/transaction/pane.js - About 4 hrs to fix

              Function showNobj has 105 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    tr.showNobj = function (n) {
        var predDups = k - dups
        var show = 2 * n < predDups ? n : predDups
        var showLaterArray = []
        if (predDups !== 1) {
              Severity: Major
              Found in src/outline/manager.js - About 4 hrs to fix

                Function makeQueryRow has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                Open

                function makeQueryRow (q, tr, constraint) {
  var kb = UI.store
  // predtr = predParentOf(tr)
  // var nodes = tr.childNodes
  // var n = tr.childNodes.length
                Severity: Minor
                Found in src/outline/queryByExample.js - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function render has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                Open

                  render: function (subject, context) {
    const myDocument = context.dom
    var kb = context.store
    var ns = UI.ns
    var CAL = $rdf.Namespace('http://www.w3.org/2002/12/cal/ical#')
                Severity: Minor
                Found in src/trip/tripPane.js - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function insertTermTo has 101 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    insertTermTo: function insertTermTo (selectedTd, term, isObject) {
      switch (selectedTd.className) {
        case 'undetermined selected':
          var defaultpropview = this.views.defaults[
            selectedTd.parentNode.AJAR_statement.predicate.uri
                Severity: Major
                Found in src/outline/userInput.js - About 4 hrs to fix

                  Function render has 99 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    render: function (subject, context) {
    const myDocument = context.dom
    var kb = context.store
    var ns = UI.ns
    var CAL = $rdf.Namespace('http://www.w3.org/2002/12/cal/ical#')
                  Severity: Major
                  Found in src/trip/tripPane.js - About 3 hrs to fix

                    Function mbSubmitPost has 99 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                          var mbSubmitPost = function () {
        var meta = {
          recipients: []
        }
        // user has selected a microblog to post to
                    Severity: Major
                    Found in src/microblogPane/microblogPane.js - About 3 hrs to fix

                      Function render has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
                      Open

                        render: function (subject, context) {
    const dom = context.dom
    const store = context.session.store
    const canonizedSubject = store.canon(subject)
    const types = store.findTypeURIs(canonizedSubject)
                      Severity: Minor
                      Found in src/internal/internalPane.ts - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        label: function (subject, context) {
    var kb = context.session.store
    var typeURIs = kb.findTypeURIs(subject)

    var prefix = $rdf.Util.mediaTypeClass('audio/*').uri.split('*')[0]
                      Severity: Major
                      Found in src/audio/audioPane.js and 1 other location - About 3 hrs to fix
                      src/video/videoPane.js on lines 13..22

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 110.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        label: function (subject, context) {
    var kb = context.session.store
    var typeURIs = kb.findTypeURIs(subject)
    var prefix = $rdf.Util.mediaTypeClass('video/*').uri.split('*')[0]
    for (var t in typeURIs) {
                      Severity: Major
                      Found in src/video/videoPane.js and 1 other location - About 3 hrs to fix
                      src/audio/audioPane.js on lines 14..23

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 110.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        this.selectAll = function () {
    var i
    for (i = 0; i < 6; i++) {
      this.display.document.checkboxes.elements[i].checked = true
      this.references[i].checked = true
                      Severity: Major
                      Found in src/outline/licenseOptions.js and 1 other location - About 3 hrs to fix
                      src/outline/licenseOptions.js on lines 69..76

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 107.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        this.deselectAll = function () {
    var i
    for (i = 0; i < 6; i++) {
      this.display.document.checkboxes.elements[i].checked = false
      this.references[i].checked = false
                      Severity: Major
                      Found in src/outline/licenseOptions.js and 1 other location - About 3 hrs to fix
                      src/outline/licenseOptions.js on lines 60..67

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 107.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language