Sign upLogin

microting/eform-sdk-dotnet

View on GitHub
Star
eFormCore/Infrastructure/Data/Entities/Field.cs

Summary

Maintainability
F
4 days
Test Coverage

Method MoveTranslations has a Cognitive Complexity of 126 (exceeds 20 allowed). Consider refactoring.
Open

        public static async Task MoveTranslations(MicrotingDbContext dbContext)
        {
            try
            {
                List<Field> fields = await dbContext.Fields.ToListAsync();
Severity: Minor
Found in eFormCore/Infrastructure/Data/Entities/Field.cs - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method MoveTranslations has 173 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public static async Task MoveTranslations(MicrotingDbContext dbContext)
        {
            try
            {
                List<Field> fields = await dbContext.Fields.ToListAsync();
Severity: Major
Found in eFormCore/Infrastructure/Data/Entities/Field.cs - About 6 hrs to fix

    File Field.cs has 272 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    using System;
using System.Collections.Generic;
using System.ComponentModel.DataAnnotations;
using System.ComponentModel.DataAnnotations.Schema;
using System.Linq;
    Severity: Minor
    Found in eFormCore/Infrastructure/Data/Entities/Field.cs - About 2 hrs to fix

      Avoid deeply nested control flow statements.
      Open

                                      if (fieldOption == null)
                                {
                                    fieldOption = new FieldOption
                                    {
                                        FieldId = field.Id,
      Severity: Major
      Found in eFormCore/Infrastructure/Data/Entities/Field.cs - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                        if (currentTranslationText == translation.Text &&
                                    currentTranslationDescription == translation.Description)
                                {
                                    dbContext.FieldTranslations.Remove(translation);
                                    await dbContext.SaveChangesAsync();
        Severity: Major
        Found in eFormCore/Infrastructure/Data/Entities/Field.cs - About 45 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  private static string Locate(string textStr, string startStr, string endStr)
        {
            try
            {
                if (!textStr.Contains(startStr))
          Severity: Major
          Found in eFormCore/Infrastructure/Data/Entities/Field.cs and 1 other location - About 2 hrs to fix
          eFormCore/Tools.cs on lines 158..177

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 158.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                  {
                            fieldTranslation =
                                await dbContext.FieldTranslations.FirstOrDefaultAsync(x =>
                                    x.LanguageId == englishLanguage.Id && x.FieldId == field.Id);
                            if (fieldTranslation != null)
          Severity: Major
          Found in eFormCore/Infrastructure/Data/Entities/Field.cs and 1 other location - About 1 hr to fix
          eFormCore/Infrastructure/Data/Entities/Field.cs on lines 247..261

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                  {
                            fieldTranslation =
                                await dbContext.FieldTranslations.FirstOrDefaultAsync(x =>
                                    x.LanguageId == englishLanguage.Id && x.FieldId == field.Id);
                            if (fieldTranslation != null)
          Severity: Major
          Found in eFormCore/Infrastructure/Data/Entities/Field.cs and 1 other location - About 1 hr to fix
          eFormCore/Infrastructure/Data/Entities/Field.cs on lines 263..277

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (!string.IsNullOrEmpty(field.Label))
                    {
                        FieldTranslation fieldTranslation = new FieldTranslation
                        {
                            Text = field.Label,
          Severity: Major
          Found in eFormCore/Infrastructure/Data/Entities/Field.cs and 1 other location - About 1 hr to fix
          eFormCore/Infrastructure/Data/Entities/CheckList.cs on lines 148..161

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status