Sign upLogin

microting/eform-sdk-dotnet

View on GitHub
Star
eFormCore/Infrastructure/Data/Entities/Question.cs

Summary

Maintainability
C
7 hrs
Test Coverage

Method GenerateSmileyOptions has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private async Task GenerateSmileyOptions(MicrotingDbContext dbContext, int languageId)
        {
            string[] smileys = { "" };
            switch (QuestionType)
            {
Severity: Minor
Found in eFormCore/Infrastructure/Data/Entities/Question.cs - About 1 hr to fix

    Method GenerateSpecialQuestionTypes has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            private async Task GenerateSpecialQuestionTypes(MicrotingDbContext dbContext, int languageId)
        {
            switch (QuestionType)
            {
                case Constants.Constants.QuestionTypes.Number:
    Severity: Minor
    Found in eFormCore/Infrastructure/Data/Entities/Question.cs - About 1 hr to fix

      Method CreateSpecialOption has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              private async Task CreateSpecialOption(MicrotingDbContext dbContext, int weight, int weightedValue, string text,
            int languageId, int optionIndex)
        {
            var result = (from ot in dbContext.OptionTranslations
                join o in dbContext.Options
      Severity: Minor
      Found in eFormCore/Infrastructure/Data/Entities/Question.cs - About 1 hr to fix

        Method MapVersions has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                private QuestionVersion MapVersions(Question question)
        {
            return new QuestionVersion
            {
                QuestionSetId = question.QuestionSetId,
        Severity: Minor
        Found in eFormCore/Infrastructure/Data/Entities/Question.cs - About 1 hr to fix

          Method CreateSpecialOption has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  private async Task CreateSpecialOption(MicrotingDbContext dbContext, int weight, int weightedValue, string text,
            int languageId, int optionIndex)
          Severity: Minor
          Found in eFormCore/Infrastructure/Data/Entities/Question.cs - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            case Constants.Constants.QuestionTypes.Number:
                    await CreateSpecialOption(dbContext, 1, 0, "number", languageId, 1);
                    await CreateSpecialOption(dbContext, 1, 0, "na", languageId, 2);
                    break;
            Severity: Minor
            Found in eFormCore/Infrastructure/Data/Entities/Question.cs and 1 other location - About 40 mins to fix
            eFormCore/Infrastructure/Data/Entities/Question.cs on lines 182..185

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            case Constants.Constants.QuestionTypes.Text:
                    await CreateSpecialOption(dbContext, 1, 0, "text", languageId, 1);
                    await CreateSpecialOption(dbContext, 1, 0, "na", languageId, 2);
                    break;
            Severity: Minor
            Found in eFormCore/Infrastructure/Data/Entities/Question.cs and 1 other location - About 40 mins to fix
            eFormCore/Infrastructure/Data/Entities/Question.cs on lines 178..181

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status